Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/apollo-explorer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
},
"dependencies": {
"@apollo/explorer": "^2.0.0",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly pins @backstage/core-components to an old version (0.1.0) and removes the workspace:^ protocol. The current version in the monorepo is 0.13.4-next.0. This is a significant downgrade and breaks the project's dependency management strategy. This should be reverted. The underlying security vulnerability should be fixed using yarn resolutions in the root package.json.

Suggested change
"@backstage/core-components": "0.1.0",
"@backstage/core-components": "workspace:^",

"@backstage/core-plugin-api": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Similar to the change for @backstage/core-components, this incorrectly pins @backstage/theme to an old version (0.1.1) and removes the workspace:^ protocol. The current version in the monorepo is 0.4.1. This is a significant downgrade and should be reverted.

Suggested change
"@backstage/theme": "0.1.1",
"@backstage/theme": "workspace:^",

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"react-use": "^17.2.4",
Expand Down
Loading