Skip to content

[Snyk] Fix for 2 vulnerabilities#12393

Closed
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-afebb1165f05ddbb310bba736cea82d7
Closed

[Snyk] Fix for 2 vulnerabilities#12393
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-afebb1165f05ddbb310bba736cea82d7

Conversation

@q1blue
Copy link
Copy Markdown
Collaborator

@q1blue q1blue commented Feb 15, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/home-react/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AJV-15274295
  157  
medium severity Allocation of Resources Without Limits or Throttling
SNYK-JS-QS-15268416
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Allocation of Resources Without Limits or Throttling


EntelligenceAI PR Summary

This PR transitions Backstage core dependencies from workspace protocol to explicit version pinning in the home-react plugin.

  • Changed @backstage/core-components dependency from workspace:^ to 0.1.0
  • Changed @backstage/core-plugin-api dependency from workspace:^ to 0.1.0
  • Shifts from monorepo workspace dependency resolution to explicit version specification
  • Affects dependency resolution strategy and package distribution approach

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Feb 15, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, focuses on improving the project's security posture by resolving two identified vulnerabilities. It achieves this by updating specific dependency versions within the plugins/home-react package. While enhancing security, users employing Yarn's zero-install feature will need to manually update their yarn.lock file.

Highlights

  • Vulnerability Remediation: This PR, automatically generated by Snyk, addresses two security vulnerabilities: a high-severity Regular Expression Denial of Service (ReDoS) (SNYK-JS-AJV-15274295) and a medium-severity Allocation of Resources Without Limits or Throttling (SNYK-JS-QS-15268416).
  • Dependency Version Updates: The plugins/home-react/package.json file was updated to explicitly set @backstage/core-components and @backstage/core-plugin-api dependencies to version 0.1.0 from workspace:^.
Changelog
  • plugins/home-react/package.json
    • Updated @backstage/core-components dependency from workspace:^ to 0.1.0.
    • Updated @backstage/core-plugin-api dependency from workspace:^ to 0.1.0.
Activity
  • Snyk automatically created this pull request to fix two identified vulnerabilities.
  • A warning was issued indicating that the yarn.lock file failed to update and requires manual intervention.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Feb 15, 2026

Snyk checks have failed. 1 issues have been found so far.

Status Scanner Critical High Medium Low Total (1)
Open Source Security 0 0 1 0 1 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, attempts to resolve two security vulnerabilities by modifying dependency versions in plugins/home-react/package.json. However, the proposed change is incorrect for this monorepo structure. It replaces workspace-local dependencies (workspace:^) with fixed, outdated versions (0.1.0), which constitutes a major downgrade and will likely break the build and application functionality. The change should be reverted, and the vulnerabilities should be addressed by updating the appropriate packages within the workspace and regenerating the lockfile. As noted in the PR description, Snyk failed to update yarn.lock, which further indicates the problem with this automated fix.

Comment on lines +36 to +37
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly replaces workspace:^ with a fixed, very old version 0.1.0 for @backstage/core-components and @backstage/core-plugin-api. This will likely break the application.

In this monorepo setup, workspace:^ ensures that this package uses the local, in-repo versions of other workspace packages. The current versions in the workspace are:

  • @backstage/core-components: 0.13.4-next.0
  • @backstage/core-plugin-api: 1.5.3

Pinning to 0.1.0 is a significant downgrade that will cause this package to fetch old versions from the registry instead of using the up-to-date code from the workspace. This will almost certainly lead to build failures and runtime errors due to API mismatches.

While the intent is to fix vulnerabilities, this approach is incorrect. The vulnerabilities should be addressed by updating dependencies within the respective packages (@backstage/core-components, @backstage/core-plugin-api, or others) or their transitive dependencies, without breaking the workspace linking.

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^"

@entelligence-ai-pr-reviews
Copy link
Copy Markdown

Walkthrough

This PR updates the dependency management strategy for the home-react plugin by replacing workspace protocol references with explicit version pinning. The change affects two core Backstage dependencies, transitioning from workspace:^ (which resolves to local monorepo packages during development) to fixed version 0.1.0. This modification suggests a move from local development dependencies to published package versions, which will impact how dependencies are resolved during installation and may indicate preparation for package publication or distribution outside the monorepo context.

Changes

File(s) Summary
plugins/home-react/package.json Updated @backstage/core-components and @backstage/core-plugin-api dependencies from workspace protocol (workspace:^) to fixed version 0.1.0.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PM as Package Manager
    participant Registry as NPM Registry
    participant HomeReact as home-react Plugin

    Note over Dev,HomeReact: Dependency Resolution Change

    Dev->>HomeReact: Update package.json
    Note right of HomeReact: Change workspace:^ to 0.1.0<br/>for core dependencies

    Dev->>PM: Run install command
    
    alt Before Change (workspace:^)
        PM->>HomeReact: Resolve dependencies
        PM->>PM: Link to local workspace packages
        Note over PM: Uses local monorepo versions
    else After Change (0.1.0)
        PM->>HomeReact: Resolve dependencies
        PM->>Registry: Fetch @backstage/core-components@0.1.0
        PM->>Registry: Fetch @backstage/core-plugin-api@0.1.0
        Registry-->>PM: Return published packages
        PM->>HomeReact: Install fixed versions
        Note over PM,HomeReact: Uses published NPM versions
    end

    PM-->>Dev: Dependencies installed
    Note over Dev,HomeReact: Plugin now uses pinned versions<br/>instead of workspace references
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Feb 22, 2026
@github-actions github-actions Bot closed this Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants