Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/home-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "0.1.0",
Comment on lines +36 to +37
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly replaces workspace:^ with a fixed, very old version 0.1.0 for @backstage/core-components and @backstage/core-plugin-api. This will likely break the application.

In this monorepo setup, workspace:^ ensures that this package uses the local, in-repo versions of other workspace packages. The current versions in the workspace are:

  • @backstage/core-components: 0.13.4-next.0
  • @backstage/core-plugin-api: 1.5.3

Pinning to 0.1.0 is a significant downgrade that will cause this package to fetch old versions from the registry instead of using the up-to-date code from the workspace. This will almost certainly lead to build failures and runtime errors due to API mismatches.

While the intent is to fix vulnerabilities, this approach is incorrect. The vulnerabilities should be addressed by updating dependencies within the respective packages (@backstage/core-components, @backstage/core-plugin-api, or others) or their transitive dependencies, without breaking the workspace linking.

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^"

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@rjsf/utils": "5.7.3"
Expand Down
Loading