forked from SDA-SE/backstage
-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 2 vulnerabilities #12393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change incorrectly replaces
workspace:^with a fixed, very old version0.1.0for@backstage/core-componentsand@backstage/core-plugin-api. This will likely break the application.In this monorepo setup,
workspace:^ensures that this package uses the local, in-repo versions of other workspace packages. The current versions in the workspace are:@backstage/core-components:0.13.4-next.0@backstage/core-plugin-api:1.5.3Pinning to
0.1.0is a significant downgrade that will cause this package to fetch old versions from the registry instead of using the up-to-date code from the workspace. This will almost certainly lead to build failures and runtime errors due to API mismatches.While the intent is to fix vulnerabilities, this approach is incorrect. The vulnerabilities should be addressed by updating dependencies within the respective packages (
@backstage/core-components,@backstage/core-plugin-api, or others) or their transitive dependencies, without breaking the workspace linking.