[Snyk] Security upgrade @backstage/config from 0.0.0-use.local to 0.1.1#12395
[Snyk] Security upgrade @backstage/config from 0.0.0-use.local to 0.1.1#12395
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-AJV-15274295 - https://snyk.io/vuln/SNYK-JS-QS-15268416
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, enhances the project's security by updating the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, aims to fix security vulnerabilities by upgrading @backstage/config. However, the proposed change from "workspace:^" to "0.1.1" is incorrect for this monorepo setup. It replaces a workspace-local dependency with a fixed, and significantly older, public version (the workspace version is 1.0.8, while this PR pins it to 0.1.1). This will likely lead to dependency conflicts, runtime errors, and break the application. The warning in the PR description about failing to update yarn.lock also indicates that the automated process failed. The correct approach would be to address the transitive vulnerabilities (in ajv and qs) using yarn's resolutions feature in the root package.json. As such, this PR should not be merged in its current state.
| }, | ||
| "dependencies": { | ||
| "@backstage/config": "workspace:^" | ||
| "@backstage/config": "0.1.1" |
There was a problem hiding this comment.
This change incorrectly replaces a yarn workspace dependency with a fixed, outdated version. The workspace:^ protocol ensures that this package uses the version of @backstage/config from within this monorepo (currently 1.0.8).
By pinning the version to 0.1.1, you are introducing a significant downgrade that will cause this package to use a different version of @backstage/config than the rest of the application. This will likely lead to build failures or subtle runtime bugs.
The correct way to resolve the underlying security vulnerabilities in a monorepo is typically to use resolutions in the root package.json to force a newer, secure version of the transitive dependencies. This PR should not be merged as is.
| "@backstage/config": "0.1.1" | |
| "@backstage/config": "workspace:^" |
WalkthroughThis pull request modifies the dependency management for the lighthouse-common plugin by changing how the '@backstage/config' package is referenced. The change transitions from using a workspace protocol reference (which resolves to local monorepo packages during development) to a pinned version specification (0.1.1). This modification likely indicates preparation for publishing the package independently, resolving version compatibility issues, or standardizing dependency versions across the codebase. The change affects only the package.json file and does not introduce any functional code changes. Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Build as Build System
participant LH as lighthouse-common Plugin
participant PM as Package Manager
participant WS as Workspace
participant NPM as NPM Registry
Note over LH,NPM: Dependency Resolution Change
rect rgb(240, 240, 240)
Note over Build,WS: OLD: workspace:^ reference
Build->>PM: Install dependencies for lighthouse-common
PM->>WS: Resolve @backstage/config (workspace:^)
WS-->>PM: Return local workspace package
PM-->>LH: Link local @backstage/config
end
rect rgb(220, 250, 220)
Note over Build,NPM: NEW: Fixed version 0.1.1
Build->>PM: Install dependencies for lighthouse-common
PM->>NPM: Fetch @backstage/config@0.1.1
NPM-->>PM: Return published package v0.1.1
PM-->>LH: Install @backstage/config@0.1.1
end
Note over LH: lighthouse-common now uses<br/>published version instead of<br/>workspace reference
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
2 participants
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/lighthouse-common/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-AJV-15274295
SNYK-JS-QS-15268416
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Allocation of Resources Without Limits or Throttling
EntelligenceAI PR Summary
This PR updates the dependency specification for '@backstage/config' in the lighthouse-common plugin from workspace protocol to a fixed version.