Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/lighthouse-common/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"url": "https://github.com/backstage/backstage/issues"
},
"dependencies": {
"@backstage/config": "workspace:^"
"@backstage/config": "0.1.1"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly replaces a yarn workspace dependency with a fixed, outdated version. The workspace:^ protocol ensures that this package uses the version of @backstage/config from within this monorepo (currently 1.0.8).

By pinning the version to 0.1.1, you are introducing a significant downgrade that will cause this package to use a different version of @backstage/config than the rest of the application. This will likely lead to build failures or subtle runtime bugs.

The correct way to resolve the underlying security vulnerabilities in a monorepo is typically to use resolutions in the root package.json to force a newer, secure version of the transitive dependencies. This PR should not be merged as is.

Suggested change
"@backstage/config": "0.1.1"
"@backstage/config": "workspace:^"

},
"devDependencies": {
"@backstage/cli": "workspace:^"
Expand Down
Loading