[Snyk] Security upgrade @backstage/plugin-permission-common from 0.0.0-use.local to 0.1.0#12397
[Snyk] Security upgrade @backstage/plugin-permission-common from 0.0.0-use.local to 0.1.0#12397
Conversation
…ilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-AJV-15274295 - https://snyk.io/vuln/SNYK-JS-QS-15268416
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Summary of ChangesHello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to enhance the project's security by upgrading a key dependency. It addresses critical vulnerabilities, including a high-severity ReDoS and a medium-severity resource allocation issue, ensuring a more robust and secure application environment. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, aims to fix security vulnerabilities by upgrading @backstage/plugin-permission-common. However, the proposed change of pinning the version to 0.1.0 in plugins/example-todo-list-common/package.json is incorrect for this monorepo structure. It replaces the workspace:^ protocol, which is essential for linking local packages in a yarn workspace environment. This change would cause the project to use an outdated, published version of the package instead of the local one, likely breaking the build and local development. The change should be reverted to maintain the integrity of the monorepo's dependency management.
| }, | ||
| "dependencies": { | ||
| "@backstage/plugin-permission-common": "workspace:^" | ||
| "@backstage/plugin-permission-common": "0.1.0" |
There was a problem hiding this comment.
Changing the dependency from workspace:^ to a specific version 0.1.0 is incorrect for this monorepo setup. It breaks the yarn workspace linking, causing this package to use an old, published version of @backstage/plugin-permission-common instead of the local one (which is version 0.7.7 in this workspace). This will likely lead to build failures or runtime issues due to version mismatches. The workspace:^ protocol should be preserved to ensure local packages are correctly linked.
| "@backstage/plugin-permission-common": "0.1.0" | |
| "@backstage/plugin-permission-common": "workspace:^" |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
WalkthroughThis pull request updates the dependency management for the example-todo-list-common plugin by transitioning from a workspace protocol reference to a fixed version for the @backstage/plugin-permission-common package. The change replaces the flexible workspace:^ reference with a pinned version 0.1.0, indicating a shift from local monorepo development to using published package versions. This type of change is typically made when preparing a package for publication or when standardizing dependency versions across a distributed package ecosystem. Changes
Sequence DiagramThis diagram shows the interactions between components: sequenceDiagram
participant Dev as Developer
participant PM as Package Manager
participant WS as Workspace
participant NPM as NPM Registry
participant Plugin as example-todo-list-common
Note over Dev,Plugin: Dependency Resolution Change
Dev->>Plugin: Update package.json
Note right of Plugin: Change dependency from<br/>workspace:^ to 0.1.0
Dev->>PM: Run install command
alt Before Change (workspace:^)
PM->>WS: Resolve @backstage/plugin-permission-common
WS-->>PM: Return local workspace version
PM->>Plugin: Link workspace dependency
else After Change (0.1.0)
PM->>NPM: Fetch @backstage/plugin-permission-common@0.1.0
NPM-->>PM: Return published package
PM->>Plugin: Install fixed version dependency
end
Note over Plugin: Dependency now pinned to<br/>specific published version
Note for WindsurfPlease change the default marketplace provider to the following in the windsurf settings:Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts belowEmoji Descriptions:
Interact with the Bot:
Also you can trigger various commands with the bot by doing The current supported commands are
More commands to be added soon. |
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
2 participants
Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/example-todo-list-common/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-AJV-15274295
SNYK-JS-QS-15268416
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Regular Expression Denial of Service (ReDoS)
🦉 Allocation of Resources Without Limits or Throttling
EntelligenceAI PR Summary
This PR pins the @backstage/plugin-permission-common dependency to a specific version in the example-todo-list-common plugin.
workspace:^to0.1.0inplugins/example-todo-list-common/package.json