Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions plugins/techdocs-addons-test-utils/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,11 @@
"@backstage/core-plugin-api": "workspace:^",
"@backstage/integration-react": "workspace:^",
"@backstage/plugin-catalog": "workspace:^",
"@backstage/plugin-search-react": "workspace:^",
"@backstage/plugin-techdocs": "workspace:^",
"@backstage/plugin-techdocs-react": "workspace:^",
"@backstage/test-utils": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-search-react": "0.1.0",
"@backstage/plugin-techdocs": "0.1.1",
"@backstage/plugin-techdocs-react": "0.1.0",
"@backstage/test-utils": "0.1.1",
"@backstage/theme": "0.1.1",
Comment on lines +40 to +44
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes introduce significant downgrades to several @backstage packages, which are likely to be breaking changes and could cause runtime errors or unexpected behavior. For example, @backstage/plugin-search-react is being downgraded from a version compatible with 1.6.4-next.0 (from the workspace) to 0.1.0.

A safer approach to fix the underlying vulnerabilities in ajv and qs is to use Yarn's resolutions feature in your root package.json. This allows you to force specific versions of transitive dependencies across your entire project without downgrading your direct dependencies.

I recommend reverting these changes and adding the following to your root package.json:

"resolutions": {
  "ajv": "^8.12.0",
  "qs": "^6.11.1"
}

After adding the resolutions, run yarn install to update the yarn.lock file.

    "@backstage/plugin-search-react": "workspace:^",
    "@backstage/plugin-techdocs": "workspace:^",
    "@backstage/plugin-techdocs-react": "workspace:^",
    "@backstage/test-utils": "workspace:^",
    "@backstage/theme": "workspace:^"

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading