Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/integration-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@
},
"dependencies": {
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly downgrades @backstage/core-components from a workspace dependency to a very old version (0.1.0). This will likely break the application. To fix the underlying vulnerability correctly in this monorepo, please use resolutions in the root package.json to force a non-vulnerable version of the transitive dependency.

Suggested change
"@backstage/core-components": "0.1.0",
"@backstage/core-components": "workspace:^",

"@backstage/core-plugin-api": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/integration": "0.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Similar to the change for @backstage/core-components, this incorrectly downgrades @backstage/integration to a very old version (0.1.0). This will also likely cause breakages. Please revert this change and use resolutions to address the vulnerability.

Suggested change
"@backstage/integration": "0.1.0",
"@backstage/integration": "workspace:^",

"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading