Skip to content

[Snyk] Fix for 2 vulnerabilities#12413

Closed
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-fa65b27d20c4d2796310f1bcb4388499
Closed

[Snyk] Fix for 2 vulnerabilities#12413
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-fa65b27d20c4d2796310f1bcb4388499

Conversation

@q1blue
Copy link
Copy Markdown
Collaborator

@q1blue q1blue commented Feb 15, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/badges-backend/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AJV-15274295
  157  
medium severity Allocation of Resources Without Limits or Throttling
SNYK-JS-QS-15268416
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Allocation of Resources Without Limits or Throttling


EntelligenceAI PR Summary

This PR updates dependency versions in the badges-backend plugin to lock specific versions and upgrade external packages.

  • Changed @backstage/backend-common from workspace protocol to 0.24.1
  • Changed @backstage/catalog-model from workspace protocol to 0.1.1
  • Changed @backstage/plugin-auth-node from workspace protocol to 0.6.0
  • Upgraded express from ^4.17.1 to ^4.22.0
  • Upgraded supertest from ^6.3.3 to ^7.1.3

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Feb 15, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to bolster the project's security by resolving two significant vulnerabilities. It achieves this by updating several core package dependencies, thereby protecting the application from potential denial-of-service attacks and resource exhaustion issues.

Highlights

  • Security Vulnerability Fixes: This pull request addresses two critical security vulnerabilities: a high-severity Regular Expression Denial of Service (ReDoS) (SNYK-JS-AJV-15274295) and a medium-severity Allocation of Resources Without Limits or Throttling (SNYK-JS-QS-15268416).
  • Dependency Upgrades: Key dependencies in plugins/badges-backend/package.json have been upgraded to their latest versions to mitigate the identified security risks.
Changelog
  • plugins/badges-backend/package.json
    • Updated @backstage/backend-common from workspace:^ to 0.24.1.
    • Updated @backstage/catalog-model from workspace:^ to 0.1.1.
    • Updated @backstage/plugin-auth-node from workspace:^ to 0.6.0.
    • Updated express from ^4.17.1 to ^4.22.0.
    • Updated supertest from ^6.3.3 to ^7.1.3.
Activity
  • This pull request was automatically created by Snyk to provide fixes for identified vulnerabilities.
  • Snyk reported that the yarn.lock file failed to update and requires manual intervention before merging.
  • A note was included for zero-install users regarding the .yarn/cache/ directory not being updated.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Feb 15, 2026

Snyk checks have failed. 1 issues have been found so far.

Status Scanner Critical High Medium Low Total (1)
Open Source Security 0 0 1 0 1 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix two security vulnerabilities by updating dependencies. While the updates to external packages like express and supertest are appropriate, the changes to internal workspace packages (@backstage/...) are incorrect. The PR replaces workspace:^ references with pinned versions from the public registry, which goes against the monorepo's dependency management strategy and could break the build. I've provided a suggestion to revert the changes for the internal packages. The underlying vulnerabilities should be addressed by updating the dependencies within the respective workspace packages.

Comment on lines +36 to +42
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/catalog-client": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-auth-node": "0.6.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated change incorrectly replaces workspace dependencies (workspace:^) with pinned versions from the public registry. This breaks the monorepo's dependency management strategy and can lead to build failures or multiple versions of the same package in the final bundle.

The correct way to fix the underlying vulnerabilities is to update the dependencies within the respective workspace packages (e.g., update ajv in @backstage/catalog-model).

These changes should be reverted to use workspace:^.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/catalog-client": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-auth-node": "workspace:^"

@entelligence-ai-pr-reviews
Copy link
Copy Markdown

Walkthrough

This PR updates dependency versions in the badges-backend plugin's package.json. The changes migrate three Backstage internal dependencies from workspace protocol to fixed versions, ensuring version stability across the plugin. The @backstage/backend-common is updated to 0.24.1, @backstage/catalog-model to 0.1.1, and @backstage/plugin-auth-node to 0.6.0. Additionally, two external dependencies are upgraded: express is bumped from ^4.17.1 to ^4.22.0, and supertest from ^6.3.3 to ^7.1.3. These updates likely address security vulnerabilities and improve package stability by locking to specific versions.

Changes

File(s) Summary
plugins/badges-backend/package.json Updated Backstage internal dependencies from workspace protocol to fixed versions: @backstage/backend-common to 0.24.1, @backstage/catalog-model to 0.1.1, @backstage/plugin-auth-node to 0.6.0. Upgraded external dependencies: express from ^4.17.1 to ^4.22.0 and supertest from ^6.3.3 to ^7.1.3.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PM as Package Manager
    participant Deps as Dependencies
    
    Note over Dev,Deps: Dependency Version Update (No Code Changes)
    
    Dev->>PM: Update package.json versions
    activate PM
    
    Note over PM: Version changes:<br/>- backend-common: workspace → 0.24.1<br/>- catalog-model: workspace → 0.1.1<br/>- plugin-auth-node: workspace → 0.6.0<br/>- express: 4.17.1 → 4.22.0<br/>- supertest: 6.3.3 → 7.1.3
    
    PM->>Deps: Resolve new dependency versions
    activate Deps
    Deps-->>PM: Dependencies resolved
    deactivate Deps
    
    PM->>PM: Update lock file
    PM-->>Dev: Dependencies updated
    deactivate PM
    
    Note over Dev,Deps: No functional code changes<br/>Component interactions remain unchanged
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Feb 23, 2026
@github-actions github-actions Bot closed this Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants