Skip to content

[Snyk] Fix for 2 vulnerabilities #12420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #12420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/search-backend-module-pg/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/plugin-search-backend-node": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-backend-node": "0.1.2",
"@backstage/plugin-search-common": "0.3.1",
Comment on lines +39 to +43
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency changes appear to be incorrect for this monorepo setup. The workspace:^ protocol is used to link to other packages within this repository. Replacing them with pinned versions from a public registry can lead to issues. In particular:

  • @backstage/plugin-search-backend-node is downgraded from the workspace version 1.2.4-next.0 to 0.1.2.
  • @backstage/plugin-search-common is downgraded from the workspace version 1.2.5 to 0.3.1.

These significant downgrades will likely break the build and introduce API incompatibilities. The correct approach is to address the vulnerabilities (in ajv and qs) by either updating the responsible packages across the monorepo or using resolutions in the root package.json, while keeping the workspace:^ references.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/plugin-search-backend-node": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-backend-node": "0.1.2",
"@backstage/plugin-search-common": "0.3.1",
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/plugin-search-backend-node": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",

"knex": "^2.0.0",
"lodash": "^4.17.21",
"uuid": "^8.3.2",
Expand Down
Loading