Skip to content

[Snyk] Fix for 2 vulnerabilities #12424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #12424

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/git-release-manager/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,17 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/integration": "0.1.0",
Comment on lines +26 to +28
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Pinning @backstage/core-components and @backstage/integration to a very old version 0.1.0 is incorrect. This change removes the workspace:^ specifier, which means this package will no longer use the local versions from the monorepo. This will likely cause build failures or runtime errors due to API mismatches, as the current versions in the workspace are much newer (0.13.4-next.0 for core-components and 1.5.1 for integration).

To fix the underlying transitive vulnerability in ajv, a safer approach is to use yarn's resolutions feature in the root package.json to force a non-vulnerable version of ajv across the entire workspace.

I recommend reverting these changes.

Suggested change
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/integration": "0.1.0",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/integration": "workspace:^",

"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
"@octokit/rest": "^19.0.3",
"@types/react": "^16.13.1 || ^17.0.0",
"luxon": "^3.0.0",
"qs": "^6.10.1",
"qs": "^6.14.2",
"react-use": "^17.2.4",
"recharts": "^2.5.0"
},
Expand Down
Loading