Skip to content

[Snyk] Fix for 2 vulnerabilities#12425

Closed
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-0d7531485acd2b8643513103b39402a5
Closed

[Snyk] Fix for 2 vulnerabilities#12425
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-0d7531485acd2b8643513103b39402a5

Conversation

@q1blue
Copy link
Copy Markdown
Collaborator

@q1blue q1blue commented Feb 16, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/dynatrace/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AJV-15274295
  157  
medium severity Allocation of Resources Without Limits or Throttling
SNYK-JS-QS-15268416
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Allocation of Resources Without Limits or Throttling


EntelligenceAI PR Summary

This PR transitions the Dynatrace plugin from workspace-based dependency management to explicit version pinning for Backstage packages.

  • Changed @backstage/catalog-model from workspace:^ to version 0.1.1
  • Changed @backstage/core-components from workspace:^ to version 0.1.0
  • Changed @backstage/theme from workspace:^ to version 0.1.1
  • Modified plugins/dynatrace/package.json to support independent plugin distribution or stricter version control

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Feb 16, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by resolving two identified vulnerabilities within the yarn dependencies. The changes involve specific dependency version upgrades to mitigate risks associated with Regular Expression Denial of Service and resource allocation issues.

Highlights

  • Vulnerability Fixes: Addresses two security vulnerabilities: a high-severity Regular Expression Denial of Service (ReDoS) (SNYK-JS-AJV-15274295) and a medium-severity Allocation of Resources Without Limits or Throttling (SNYK-JS-QS-15268416).
  • Dependency Updates: Upgraded @backstage/catalog-model to 0.1.1, @backstage/core-components to 0.1.0, and @backstage/theme to 0.1.1 in plugins/dynatrace/package.json.
Changelog
  • plugins/dynatrace/package.json
    • Updated @backstage/catalog-model from workspace:^ to 0.1.1.
    • Updated @backstage/core-components from workspace:^ to 0.1.0.
    • Updated @backstage/theme from workspace:^ to 0.1.1.
Activity
  • This pull request was automatically created by Snyk to fix identified vulnerabilities.
  • A warning was noted that the yarn.lock file failed to update and requires manual intervention before merging.
  • Guidance was provided for zero-installs users regarding the .yarn/cache directory.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Feb 16, 2026

Snyk checks have failed. 2 issues have been found so far.

Status Scanner Critical High Medium Low Total (2)
Open Source Security 0 0 2 0 2 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@socket-security
Copy link
Copy Markdown

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
License policy violation: npm atob under CC-BY-3.0

License: CC-BY-3.0 - the applicable license policy does not allow this license (4) (package/LICENSE.DOCS)

From: ?npm/atob@2.1.2

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/atob@2.1.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@entelligence-ai-pr-reviews
Copy link
Copy Markdown

Walkthrough

This PR updates the dependency management strategy for the Dynatrace plugin by replacing workspace protocol references with explicit version numbers for three Backstage packages. The changes affect @backstage/catalog-model (now pinned to 0.1.1), @backstage/core-components (now pinned to 0.1.0), and @backstage/theme (now pinned to 0.1.1). This transition from workspace:^ to specific versions suggests the plugin is being prepared for independent distribution outside of a monorepo environment, or establishing stricter version control for better dependency management and reproducibility.

Changes

File(s) Summary
plugins/dynatrace/package.json Updated three Backstage package dependencies from workspace protocol (workspace:^) to explicit versions: @backstage/catalog-model to 0.1.1, @backstage/core-components to 0.1.0, and @backstage/theme to 0.1.1.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant Plugin as Dynatrace Plugin
    participant PM as Package Manager
    participant Deps as Backstage Dependencies

    Dev->>Plugin: Update package.json
    Note over Plugin: Change workspace:^ to fixed versions<br/>- catalog-model: 0.1.1<br/>- core-components: 0.1.0<br/>- theme: 0.1.1
    
    Dev->>PM: Run install/build
    PM->>Deps: Resolve @backstage/catalog-model
    Deps-->>PM: Return v0.1.1 (pinned)
    PM->>Deps: Resolve @backstage/core-components
    Deps-->>PM: Return v0.1.0 (pinned)
    PM->>Deps: Resolve @backstage/theme
    Deps-->>PM: Return v0.1.1 (pinned)
    
    PM-->>Plugin: Dependencies installed with fixed versions
    Plugin-->>Dev: Build successful with pinned dependencies
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, attempts to fix two security vulnerabilities by updating dependencies in plugins/dynatrace/package.json. However, the proposed changes are incorrect for this monorepo setup. They replace workspace-local dependencies (workspace:^) with specific, severely outdated versions from the public registry. This is a critical issue that will likely break the build and cause runtime errors due to API incompatibilities. I have added a comment with a suggestion to revert these changes and have outlined the correct approach, which involves updating the vulnerable transitive dependencies in their respective packages within the monorepo.

Comment on lines +30 to +33
"@backstage/catalog-model": "0.1.1",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency changes are incorrect and will likely break the application. They are downgrading @backstage/catalog-model, @backstage/core-components, and @backstage/theme to very old versions and removing the workspace:^ protocol.

In a monorepo using Yarn workspaces, workspace:^ ensures that local packages are used. By replacing it with specific old versions, you are forcing yarn to fetch outdated packages from the registry, which will likely be incompatible with the rest of the codebase.

For example:

  • @backstage/catalog-model is being downgraded from workspace version 1.4.1 to 0.1.1.
  • @backstage/core-components is being downgraded from workspace version 0.13.4-next.0 to 0.1.0.

The correct way to fix the reported vulnerabilities in ajv and qs is to update those dependencies in their respective package.json files (packages/catalog-model/package.json for ajv and packages/core-components/package.json for qs), not to downgrade packages that depend on them.

These changes should be reverted.

    "@backstage/catalog-model": "workspace:^",
    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/theme": "workspace:^"

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Feb 23, 2026
@github-actions github-actions Bot closed this Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants