Skip to content

[Snyk] Fix for 2 vulnerabilities #12425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #12425

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/dynatrace/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Comment on lines +30 to +33
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency changes are incorrect and will likely break the application. They are downgrading @backstage/catalog-model, @backstage/core-components, and @backstage/theme to very old versions and removing the workspace:^ protocol.

In a monorepo using Yarn workspaces, workspace:^ ensures that local packages are used. By replacing it with specific old versions, you are forcing yarn to fetch outdated packages from the registry, which will likely be incompatible with the rest of the codebase.

For example:

  • @backstage/catalog-model is being downgraded from workspace version 1.4.1 to 0.1.1.
  • @backstage/core-components is being downgraded from workspace version 0.13.4-next.0 to 0.1.0.

The correct way to fix the reported vulnerabilities in ajv and qs is to update those dependencies in their respective package.json files (packages/catalog-model/package.json for ajv and packages/core-components/package.json for qs), not to downgrade packages that depend on them.

These changes should be reverted.

    "@backstage/catalog-model": "workspace:^",
    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/theme": "workspace:^"

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading