Skip to content

[Snyk] Fix for 2 vulnerabilities #12426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #12426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/kafka/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,11 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/plugin-catalog-react": "1.0.0",
Comment on lines +27 to +31
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes downgrade several @backstage packages to very old versions (e.g., @backstage/catalog-model from what is likely a much newer workspace version to 0.1.1). This is likely to cause breaking changes and runtime errors due to API incompatibilities. I've suggested reverting these changes.

While this might resolve the Snyk vulnerabilities in transitive dependencies, it's not the correct approach. A better way to resolve these vulnerabilities in a yarn workspace project is to use resolutions in the root package.json to force the vulnerable packages (ajv, qs) to a non-vulnerable version. For example:

"resolutions": {
  "ajv": "^8.12.0",
  "qs": "^6.5.3"
}

After adding the resolutions, you'll need to run yarn install to update the yarn.lock file. This PR also notes that yarn.lock was not updated, which is another critical issue that needs to be addressed.

    "@backstage/catalog-model": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/plugin-catalog-react": "workspace:^"

"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading