Skip to content

[Snyk] Fix for 2 vulnerabilities#12430

Closed
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-a4361302f085b5e80c93154f560e1a98
Closed

[Snyk] Fix for 2 vulnerabilities#12430
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-a4361302f085b5e80c93154f560e1a98

Conversation

@q1blue
Copy link
Copy Markdown
Collaborator

@q1blue q1blue commented Feb 16, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/rollbar/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AJV-15274295
  157  
medium severity Allocation of Resources Without Limits or Throttling
SNYK-JS-QS-15268416
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Allocation of Resources Without Limits or Throttling


EntelligenceAI PR Summary

This PR transitions the Rollbar plugin from workspace protocol dependencies to explicit versioned dependencies for Backstage packages.

  • Changed '@backstage/catalog-model' from workspace protocol to version 0.1.1
  • Changed '@backstage/theme' from workspace protocol to version 0.1.1
  • Changed '@backstage/plugin-catalog-react' from workspace protocol to version 1.0.0
  • Modified in plugins/rollbar/package.json

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Feb 16, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by resolving two identified vulnerabilities within the plugins/rollbar module's dependencies. It specifically targets a Regular Expression Denial of Service (ReDoS) and an Allocation of Resources Without Limits or Throttling issue by updating relevant package versions.

Highlights

  • Vulnerability Fixes: Addressed two security vulnerabilities: a high-severity Regular Expression Denial of Service (ReDoS) and a medium-severity Allocation of Resources Without Limits or Throttling.
  • Dependency Updates: Updated @backstage/catalog-model to 0.1.1, @backstage/plugin-catalog-react to 1.0.0, and @backstage/theme to 0.1.1 in plugins/rollbar/package.json to resolve the identified vulnerabilities.
Changelog
  • plugins/rollbar/package.json
    • Updated @backstage/catalog-model dependency from workspace:^ to 0.1.1.
    • Updated @backstage/plugin-catalog-react dependency from workspace:^ to 1.0.0.
    • Updated @backstage/theme dependency from workspace:^ to 0.1.1.
Activity
  • This pull request was automatically created by Snyk to address identified vulnerabilities.
  • A warning was noted that yarn.lock failed to update and requires manual intervention.
  • Snyk provided links to view the latest project report, customize PR templates, adjust project settings, and read about Snyk's upgrade logic.
  • Snyk also included links to interactive lessons on the fixed vulnerabilities.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Feb 16, 2026

Snyk checks have failed. 1 issues have been found so far.

Status Scanner Critical High Medium Low Total (1)
Open Source Security 0 0 1 0 1 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix two security vulnerabilities by updating dependencies. However, the proposed changes are highly problematic as they involve significant downgrades of several @backstage packages and replace workspace: specifiers with fixed versions from a public registry. This approach is very likely to cause breaking changes and conflicts with the monorepo's dependency management strategy. The PR description also notes that yarn.lock failed to update, which further suggests dependency resolution issues. It is strongly recommended to reject these changes and instead address the vulnerabilities by updating the transitive dependencies (ajv and qs) within their respective source packages in this repository.

Comment on lines +36 to +40
"@backstage/catalog-model": "0.1.1",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "1.0.0",
"@backstage/theme": "0.1.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The automated dependency update from Snyk is likely incorrect. It replaces workspace:^ specifiers with pinned versions from the public registry, and in some cases, downgrades the packages significantly:

  • @backstage/catalog-model is changed to 0.1.1, but the version in this repository is 1.4.1.
  • @backstage/theme is changed to 0.1.1, but the version in this repository is 0.4.1.

These downgrades will likely cause build failures or runtime errors. The workspace: protocol is used to ensure packages within this monorepo are used, and replacing it breaks this convention.

The recommended action is to address the vulnerabilities (SNYK-JS-AJV-15274295 and SNYK-JS-QS-15268416) by updating the vulnerable transitive dependencies (ajv, qs) in their respective source packages within this repository, rather than accepting these changes.

@entelligence-ai-pr-reviews
Copy link
Copy Markdown

Walkthrough

This PR updates the dependency management strategy for the Rollbar plugin by replacing workspace protocol references with explicit version numbers for three Backstage packages. The changes pin '@backstage/catalog-model' and '@backstage/theme' to version 0.1.1, and '@backstage/plugin-catalog-react' to version 1.0.0. This modification transitions from local workspace dependencies to published package versions, likely in preparation for independent plugin distribution or to establish stricter version control and dependency management.

Changes

File(s) Summary
plugins/rollbar/package.json Replaced workspace protocol references with explicit version numbers for three Backstage dependencies: '@backstage/catalog-model' and '@backstage/theme' pinned to 0.1.1, '@backstage/plugin-catalog-react' pinned to 1.0.0.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PM as Package Manager
    participant Rollbar as Rollbar Plugin
    participant Deps as External Dependencies
    
    Note over Dev,Deps: Dependency Version Update Process
    
    Dev->>Rollbar: Update package.json
    Note right of Rollbar: Change workspace:^ to fixed versions<br/>- catalog-model: 0.1.1<br/>- plugin-catalog-react: 1.0.0<br/>- theme: 0.1.1
    
    Dev->>PM: Run install/build
    PM->>Deps: Resolve @backstage/catalog-model@0.1.1
    Deps-->>PM: Return package
    PM->>Deps: Resolve @backstage/plugin-catalog-react@1.0.0
    Deps-->>PM: Return package
    PM->>Deps: Resolve @backstage/theme@0.1.1
    Deps-->>PM: Return package
    
    PM->>Rollbar: Install dependencies
    PM-->>Dev: Build complete
    
    Note over Dev,Deps: Plugin now uses fixed versions<br/>instead of workspace references
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Feb 23, 2026
@github-actions github-actions Bot closed this Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants