[Snyk] Fix for 2 vulnerabilities

[q1blue]

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

• plugins/puppetdb/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning

Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

	Issue	Score
	Regular Expression Denial of Service (ReDoS) SNYK-JS-AJV-15274295	157
	Allocation of Resources Without Limits or Throttling SNYK-JS-QS-15268416	62

---

Important

• Check the changes in this PR to ensure they won't cause issues with your project.
• Max score is 1000. Note that the real score may have changed since the PR was raised.
• This PR was automatically created by Snyk using the credentials of a real user.

---

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

---

Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Allocation of Resources Without Limits or Throttling

---

EntelligenceAI PR Summary

This PR transitions the PuppetDB plugin from workspace protocol dependencies to explicit version pinning for Backstage packages.

• Changed @backstage/catalog-model from workspace protocol to version 0.1.1
• Changed @backstage/plugin-catalog-react from workspace protocol to version 1.0.0
• Changed @backstage/theme from workspace protocol to version 0.1.1
• Enables independent package publishing or resolves dependency resolution issues

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[gemini-code-assist]

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the project's security posture by resolving two critical vulnerabilities found in its yarn dependencies. It specifically targets a Regular Expression Denial of Service (ReDoS) and an Allocation of Resources Without Limits or Throttling issue by upgrading relevant @backstage packages to their patched versions. The changes are confined to the package.json file within the puppetdb plugin.

Highlights

• Vulnerability Fixes: This pull request addresses and fixes two security vulnerabilities: a high-severity Regular Expression Denial of Service (ReDoS) and a medium-severity Allocation of Resources Without Limits or Throttling.
• Dependency Updates: The fix involves updating specific @backstage dependencies in plugins/puppetdb/package.json to newer, patched versions.
• Automated Generation: This pull request was automatically generated by Snyk to provide an automated fix for the identified vulnerabilities.
• Manual yarn.lock Update Required: The yarn.lock file was not automatically updated by Snyk, requiring a manual update before merging, especially for projects using Yarn's zero-installs feature.

Changelog

• plugins/puppetdb/package.json
  • Updated the @backstage/catalog-model dependency from workspace:^ to 0.1.1.
  • Updated the @backstage/plugin-catalog-react dependency from workspace:^ to 1.0.0.
  • Updated the @backstage/theme dependency from workspace:^ to 0.1.1.

Activity

• This pull request was automatically created by Snyk to provide a fix for identified security vulnerabilities.
• Snyk detected a high-severity Regular Expression Denial of Service (ReDoS) vulnerability (SNYK-JS-AJV-15274295) and a medium-severity Allocation of Resources Without Limits or Throttling vulnerability (SNYK-JS-QS-15268416).
• The PR description notes that the yarn.lock file failed to update and requires manual intervention.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[snyk-io]

⛔ Snyk checks have failed. 1 issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (1)
⛔	Open Source Security	0	0	1	0	1 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[entelligence-ai-pr-reviews]

Walkthrough

This PR updates the PuppetDB plugin's dependency management by transitioning from workspace protocol references to explicit version pinning for three Backstage packages. The changes affect @backstage/catalog-model (pinned to 0.1.1), @backstage/plugin-catalog-react (pinned to 1.0.0), and @backstage/theme (pinned to 0.1.1). This modification moves away from monorepo workspace dependencies to fixed versioned dependencies, likely in preparation for independent package publishing or to address dependency resolution challenges in the build process.

Changes

File(s)	Summary
plugins/puppetdb/package.json	Updated three Backstage package dependencies from workspace protocol to fixed versions: @backstage/catalog-model to 0.1.1, @backstage/plugin-catalog-react to 1.0.0, and @backstage/theme to 0.1.1.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Dev as Developer
    participant PM as Package Manager
    participant WS as Workspace
    participant NPM as NPM Registry
    participant Plugin as PuppetDB Plugin

    Note over Dev,Plugin: Dependency Resolution Change

    Dev->>PM: npm install (before change)
    PM->>WS: Resolve workspace:^ dependencies
    WS-->>PM: Return local packages
    Note over WS,PM: catalog-model, plugin-catalog-react, theme<br/>from local workspace
    PM->>Plugin: Install with workspace dependencies
    
    rect rgb(240, 248, 255)
        Note over Dev,Plugin: After PR Changes
        Dev->>PM: npm install (after change)
        PM->>NPM: Fetch @backstage/catalog-model@0.1.1
        NPM-->>PM: Return package
        PM->>NPM: Fetch @backstage/plugin-catalog-react@1.0.0
        NPM-->>PM: Return package
        PM->>NPM: Fetch @backstage/theme@0.1.1
        NPM-->>PM: Return package
        PM->>Plugin: Install with pinned versions
    end
    
    Note over Plugin: Plugin now uses specific versions<br/>instead of workspace references

Loading

▶️ ⚡ AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf

Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

• ⚠️ Potential Issue - May require further investigation.
• 🔒 Security Vulnerability - Fix to ensure system safety.
• 💻 Code Improvement - Suggestions to enhance code quality.
• 🔨 Refactor Suggestion - Recommendations for restructuring code.
• ℹ️ Others - General comments and information.

Interact with the Bot:

• Send a message or request using the format:
  @entelligenceai + *your message*

Example: @entelligenceai Can you suggest improvements for this code?

• Help the Bot learn by providing feedback on its responses.
  @entelligenceai + *feedback*

Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

1. config - shows the current config
2. retrigger_review - retriggers the review

More commands to be added soon.

[gemini-code-assist]

Code Review

This pull request, automatically generated by Snyk, aims to fix two security vulnerabilities by updating dependencies. However, the proposed changes are incorrect for this project's monorepo structure. It replaces local workspace dependencies with pinned, outdated versions from a public registry, which is likely to cause significant breakages and regressions. I have left a critical comment explaining why these changes should be reverted and suggested the correct approach, which involves updating the vulnerable transitive dependencies (ajv and qs) directly within their respective packages in the monorepo.

[gemini-code-assist]

These changes incorrectly replace local workspace dependencies (workspace:^) with old, pinned versions from an external registry. This is a common issue with automated tools like Snyk in a monorepo setup. This change will likely break the build and introduce significant regressions due to the major version downgrades:

• @backstage/catalog-model: from workspace:^ (resolving to 1.4.1 in the monorepo) to 0.1.1
• @backstage/plugin-catalog-react: from workspace:^ (resolving to 1.8.1-next.0) to 1.0.0
• @backstage/theme: from workspace:^ (resolving to 0.4.1) to 0.1.1

The correct approach is to update the vulnerable transitive dependencies (ajv and qs) within their respective packages in this monorepo, and then update the yarn.lock file. These changes should be reverted.

    "@backstage/catalog-model": "workspace:^",
    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-catalog-react": "workspace:^",
    "@backstage/theme": "workspace:^"

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!