Skip to content

[Snyk] Fix for 2 vulnerabilities #12431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #12431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/puppetdb/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,12 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "1.0.0",
"@backstage/theme": "0.1.1",
Comment on lines +37 to +42
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes incorrectly replace local workspace dependencies (workspace:^) with old, pinned versions from an external registry. This is a common issue with automated tools like Snyk in a monorepo setup. This change will likely break the build and introduce significant regressions due to the major version downgrades:

  • @backstage/catalog-model: from workspace:^ (resolving to 1.4.1 in the monorepo) to 0.1.1
  • @backstage/plugin-catalog-react: from workspace:^ (resolving to 1.8.1-next.0) to 1.0.0
  • @backstage/theme: from workspace:^ (resolving to 0.4.1) to 0.1.1

The correct approach is to update the vulnerable transitive dependencies (ajv and qs) within their respective packages in this monorepo, and then update the yarn.lock file. These changes should be reverted.

    "@backstage/catalog-model": "workspace:^",
    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-catalog-react": "workspace:^",
    "@backstage/theme": "workspace:^"

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "^4.0.0-alpha.57",
Expand Down
Loading