Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions plugins/devtools-backend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,22 +22,22 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "0.1.0",
"@backstage/cli-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/config-loader": "0.1.1",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-devtools-common": "workspace:^",
"@backstage/plugin-auth-node": "0.1.0",
"@backstage/plugin-devtools-common": "0.1.0",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-node": "workspace:^",
"@backstage/plugin-permission-node": "0.1.0",
Comment on lines +25 to +34
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Replacing workspace:^ with pinned versions for these internal packages is incorrect for a monorepo. It breaks the local development workflow by fetching packages from the registry instead of the local workspace. These changes should be reverted.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "0.1.0",
"@backstage/cli-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/config-loader": "0.1.1",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-devtools-common": "workspace:^",
"@backstage/plugin-auth-node": "0.1.0",
"@backstage/plugin-devtools-common": "0.1.0",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-node": "workspace:^",
"@backstage/plugin-permission-node": "0.1.0",
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/cli-common": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/plugin-devtools-common": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-node": "workspace:^",

"@backstage/types": "workspace:^",
"@manypkg/get-packages": "^1.1.3",
"@types/express": "*",
"@yarnpkg/lockfile": "^1.1.0",
"@yarnpkg/parsers": "^3.0.0-rc.4",
"express": "^4.18.1",
"express": "^4.22.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The express package version is being updated to ^4.22.0, but this version does not exist in the npm registry. The latest version of express is 4.19.2. This will cause yarn install to fail. Please use a valid and existing version. Using ^4.19.2 should resolve the qs vulnerability.

Suggested change
"express": "^4.22.0",
"express": "^4.19.2",

"express-promise-router": "^4.1.0",
"fs-extra": "^10.0.0",
"lodash": "^4.17.21",
Expand Down
Loading