Skip to content

[Snyk] Fix for 2 vulnerabilities#12441

Closed
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-126861bcd11aad4912f4ad80d5b7d7d4
Closed

[Snyk] Fix for 2 vulnerabilities#12441
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-126861bcd11aad4912f4ad80d5b7d7d4

Conversation

@q1blue
Copy link
Copy Markdown
Collaborator

@q1blue q1blue commented Feb 16, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/adr-common/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AJV-15274295
  157  
medium severity Allocation of Resources Without Limits or Throttling
SNYK-JS-QS-15268416
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Allocation of Resources Without Limits or Throttling


EntelligenceAI PR Summary

This PR pins Backstage dependencies to specific versions in the adr-common plugin package configuration.

  • Changed @backstage/catalog-model from workspace:^ to fixed version 0.1.1
  • Changed @backstage/plugin-search-common from workspace:^ to fixed version 0.3.1
  • Replaces workspace protocol references with explicit version numbers for better version control
  • Modified in plugins/adr-common/package.json

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Feb 16, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Feb 16, 2026

Snyk checks have failed. 1 issues have been found so far.

Status Scanner Critical High Medium Low Total (1)
Open Source Security 0 0 1 0 1 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the resolution of two security vulnerabilities within the project's adr-common plugin by updating specific dependency versions in its package.json. The changes aim to enhance the project's security posture by mitigating known risks associated with outdated packages.

Highlights

  • Vulnerability Fix: This PR, automatically generated by Snyk, addresses two security vulnerabilities: a high-severity Regular Expression Denial of Service (ReDoS) (SNYK-JS-AJV-15274295) and a medium-severity Allocation of Resources Without Limits or Throttling (SNYK-JS-QS-15268416).
  • Dependency Updates: To resolve the identified vulnerabilities, the plugins/adr-common/package.json file has been updated to specify exact versions for @backstage/catalog-model (to "0.1.1") and @backstage/plugin-search-common (to "0.3.1").
  • Yarn Zero-Installs Note: Users employing Yarn's zero-installs feature should be aware that the .yarn/cache/ directory is not updated by this PR, requiring a manual yarn command to refresh the cache.
  • Manual yarn.lock Update Required: Snyk reported a failure to update yarn.lock, indicating that this file will need to be manually updated before merging to ensure consistency.
Changelog
  • plugins/adr-common/package.json
    • Updated @backstage/catalog-model dependency from workspace:^ to 0.1.1.
    • Updated @backstage/plugin-search-common dependency from workspace:^ to 0.3.1.
Activity
  • This pull request was automatically created by Snyk to fix identified vulnerabilities.
  • Snyk reported that it failed to update the yarn.lock file, which requires manual intervention.
  • A warning is provided for users of Yarn's zero-installs feature regarding the .yarn/cache/ directory.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@entelligence-ai-pr-reviews
Copy link
Copy Markdown

Walkthrough

This pull request updates dependency management for the adr-common plugin by replacing workspace protocol references with fixed version numbers. Specifically, two Backstage dependencies are pinned to explicit versions: @backstage/catalog-model is set to version 0.1.1 and @backstage/plugin-search-common is set to version 0.3.1. This change moves away from workspace-relative versioning (workspace:^) to concrete version specifications, which is typically done to ensure reproducible builds, prepare for package publication, or establish stricter version control across the project.

Changes

File(s) Summary
plugins/adr-common/package.json Updated dependency version specifications from workspace protocol (workspace:^) to fixed versions: @backstage/catalog-model to 0.1.1 and @backstage/plugin-search-common to 0.3.1.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Build as Build System
    participant ADR as adr-common Plugin
    participant CatalogModel as @backstage/catalog-model
    participant SearchCommon as @backstage/plugin-search-common

    Note over Build,SearchCommon: Dependency Resolution Change

    Build->>ADR: Install dependencies
    
    alt Before (workspace reference)
        ADR->>Build: Request workspace:^ versions
        Build->>CatalogModel: Resolve from local workspace
        Build->>SearchCommon: Resolve from local workspace
    else After (pinned versions)
        ADR->>Build: Request specific versions
        Build->>CatalogModel: Resolve version 0.1.1 from registry
        Build->>SearchCommon: Resolve version 0.3.1 from registry
    end
    
    Build-->>ADR: Dependencies installed
    
    Note over ADR: Plugin now uses pinned versions<br/>instead of workspace references
Loading

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, attempts to fix two security vulnerabilities by modifying dependencies in plugins/adr-common/package.json. However, the proposed changes are incorrect for this yarn workspace-based monorepo. It replaces workspace:^ dependencies with pinned, outdated versions of @backstage/catalog-model and @backstage/plugin-search-common. This will likely break the build and introduce regressions. The correct approach is to update the vulnerable transitive dependencies (like ajv and qs) across the workspace, likely by updating the yarn.lock file or specifying resolutions, rather than downgrading these core packages. The warning in the PR description about the failure to update yarn.lock further indicates that this automated fix is not safe to merge.

Comment on lines +32 to +34
"@backstage/catalog-model": "0.1.1",
"@backstage/integration": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-common": "0.3.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes incorrectly replace workspace-local dependencies with old, pinned versions from the public registry. This project uses yarn workspaces, and dependencies between packages in the monorepo should use workspace:^.

  • @backstage/catalog-model is being downgraded from workspace version 1.4.1 to 0.1.1.
  • @backstage/plugin-search-common is being downgraded from workspace version 1.2.5 to 0.3.1.

This is a significant downgrade that will almost certainly break the application. The correct way to fix the underlying vulnerabilities (in ajv and qs) is to update the transitive dependencies, not to downgrade these direct dependencies. Please reject this change and address the vulnerabilities by updating the yarn.lock file or adding resolutions to the root package.json.

    "@backstage/catalog-model": "workspace:^",
    "@backstage/integration": "workspace:^",
    "@backstage/plugin-search-common": "workspace:^"

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Feb 23, 2026
@github-actions github-actions Bot closed this Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants