Skip to content

[Snyk] Fix for 2 vulnerabilities #12441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #12441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/adr-common/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/integration": "workspace:^",
"@backstage/plugin-search-common": "workspace:^",
"@backstage/plugin-search-common": "0.3.1",
Comment on lines +32 to +34
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes incorrectly replace workspace-local dependencies with old, pinned versions from the public registry. This project uses yarn workspaces, and dependencies between packages in the monorepo should use workspace:^.

  • @backstage/catalog-model is being downgraded from workspace version 1.4.1 to 0.1.1.
  • @backstage/plugin-search-common is being downgraded from workspace version 1.2.5 to 0.3.1.

This is a significant downgrade that will almost certainly break the application. The correct way to fix the underlying vulnerabilities (in ajv and qs) is to update the transitive dependencies, not to downgrade these direct dependencies. Please reject this change and address the vulnerabilities by updating the yarn.lock file or adding resolutions to the root package.json.

    "@backstage/catalog-model": "workspace:^",
    "@backstage/integration": "workspace:^",
    "@backstage/plugin-search-common": "workspace:^"

"front-matter": "^4.0.2",
"luxon": "^3.0.0"
},
Expand Down
Loading