[Snyk] Fix for 2 vulnerabilities

[q1blue]

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

• plugins/catalog-backend-module-gerrit/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning

Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

	Issue	Score
	Regular Expression Denial of Service (ReDoS) SNYK-JS-AJV-15274295	157
	Allocation of Resources Without Limits or Throttling SNYK-JS-QS-15268416	62

---

Important

• Check the changes in this PR to ensure they won't cause issues with your project.
• Max score is 1000. Note that the real score may have changed since the PR was raised.
• This PR was automatically created by Snyk using the credentials of a real user.

---

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic

---

Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Allocation of Resources Without Limits or Throttling

---

EntelligenceAI PR Summary

This PR pins Backstage dependencies to specific versions in the Gerrit catalog backend module package configuration.

• Changed @backstage/backend-common from workspace:^ to 0.24.1
• Changed @backstage/catalog-model from workspace:^ to 0.1.1
• Changed @backstage/plugin-catalog-node from workspace:^ to 1.0.0
• Transitions from workspace-relative versioning to explicit version pinning for consistent dependency resolution

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[gemini-code-assist]

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, aims to enhance the security posture of the project by resolving two identified vulnerabilities: a Regular Expression Denial of Service and an Allocation of Resources Without Limits or Throttling issue. The resolution is achieved through targeted dependency upgrades within the plugins/catalog-backend-module-gerrit module. Reviewers should note the explicit requirement for manual yarn.lock updates and potential cache refreshes for zero-install environments.

Highlights

• Vulnerability Fixes: This pull request addresses two security vulnerabilities: a high-severity Regular Expression Denial of Service (ReDoS) (SNYK-JS-AJV-15274295) and a medium-severity Allocation of Resources Without Limits or Throttling (SNYK-JS-QS-15268416).
• Dependency Updates: The fix involves updating specific @backstage dependencies in plugins/catalog-backend-module-gerrit/package.json to newer, more secure versions.
• Yarn Zero-Install Note: Users utilizing Yarn's zero-install feature are advised that they will need to manually run yarn to update the .yarn/cache directory, as this PR does not modify it.
• Manual yarn.lock Update Required: A warning indicates that the yarn.lock file failed to update automatically and requires manual intervention before merging.

Changelog

• plugins/catalog-backend-module-gerrit/package.json
  • Updated @backstage/backend-common dependency from workspace:^ to 0.24.1.
  • Updated @backstage/catalog-model dependency from workspace:^ to 0.1.1.
  • Updated @backstage/plugin-catalog-node dependency from workspace:^ to 1.0.0.

Activity

• Snyk automatically created this pull request to address 2 identified vulnerabilities in the project's yarn dependencies.
• Snyk identified a high-severity Regular Expression Denial of Service (ReDoS) vulnerability (SNYK-JS-AJV-15274295) with a score of 157.
• Snyk identified a medium-severity Allocation of Resources Without Limits or Throttling vulnerability (SNYK-JS-QS-15268416) with a score of 62.
• A warning was issued stating that the yarn.lock file failed to update and requires manual intervention.
• Guidance was provided for Yarn zero-install users regarding the need to manually update the .yarn/cache directory.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[snyk-io]

⛔ Snyk checks have failed. 1 issues have been found so far.

Status	Scanner	Critical	High	Medium	Low	Total (1)
⛔	Open Source Security	0	0	1	0	1 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[entelligence-ai-pr-reviews]

Walkthrough

This pull request updates the dependency management strategy for the Gerrit catalog backend module by replacing workspace protocol references with fixed version numbers. Three core Backstage dependencies are pinned to specific versions: backend-common (0.24.1), catalog-model (0.1.1), and plugin-catalog-node (1.0.0). This change transitions from workspace-relative versioning to explicit version pinning, which is typically done to prepare a package for publication to npm or to ensure consistent dependency resolution across different development and deployment environments.

Changes

File(s)	Summary
plugins/catalog-backend-module-gerrit/package.json	Replaced workspace protocol references with fixed versions for three Backstage dependencies: @backstage/backend-common to 0.24.1, @backstage/catalog-model to 0.1.1, and @backstage/plugin-catalog-node to 1.0.0.

Sequence Diagram

This diagram shows the interactions between components:

sequenceDiagram
    participant Client
    participant GerritModule as Gerrit Catalog Module
    participant CatalogNode as plugin-catalog-node
    participant CatalogModel as catalog-model
    participant BackendCommon as backend-common
    participant GerritAPI as Gerrit API

    Note over GerritModule: Dependencies updated to<br/>fixed versions in this PR

    Client->>GerritModule: Request catalog entities
    activate GerritModule
    
    GerritModule->>BackendCommon: Use HTTP client utilities
    activate BackendCommon
    BackendCommon-->>GerritModule: HTTP client
    deactivate BackendCommon
    
    GerritModule->>GerritAPI: Fetch projects/repos
    activate GerritAPI
    GerritAPI-->>GerritModule: Project data
    deactivate GerritAPI
    
    GerritModule->>CatalogModel: Validate entity schemas
    activate CatalogModel
    CatalogModel-->>GerritModule: Validated entities
    deactivate CatalogModel
    
    GerritModule->>CatalogNode: Register entities
    activate CatalogNode
    CatalogNode-->>GerritModule: Registration complete
    deactivate CatalogNode
    
    GerritModule-->>Client: Return catalog entities
    deactivate GerritModule

Loading

▶️ ⚡ AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf

Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

• ⚠️ Potential Issue - May require further investigation.
• 🔒 Security Vulnerability - Fix to ensure system safety.
• 💻 Code Improvement - Suggestions to enhance code quality.
• 🔨 Refactor Suggestion - Recommendations for restructuring code.
• ℹ️ Others - General comments and information.

Interact with the Bot:

• Send a message or request using the format:
  @entelligenceai + *your message*

Example: @entelligenceai Can you suggest improvements for this code?

• Help the Bot learn by providing feedback on its responses.
  @entelligenceai + *feedback*

Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

1. config - shows the current config
2. retrigger_review - retriggers the review

More commands to be added soon.

[gemini-code-assist]

Code Review

This pull request, automatically generated by Snyk, attempts to fix two security vulnerabilities by updating dependencies. However, the proposed changes are incorrect for this monorepo environment. Specifically, it replaces workspace: versioning with pinned versions, which can cause dependency conflicts, and critically, it downgrades @backstage/catalog-model to a much older, incompatible version. Furthermore, the yarn.lock file has not been updated. Due to these critical issues, I recommend rejecting this PR and addressing the vulnerabilities manually by updating the transitive dependencies within the workspace and regenerating the lockfile.

[gemini-code-assist]

These dependency updates, while attempting to resolve security vulnerabilities, introduce several critical issues:

1. Incorrect Version Pinning: Replacing workspace:^ with pinned versions is an anti-pattern in a monorepo using Yarn workspaces. It can lead to multiple versions of the same package being installed, causing type mismatches and other runtime errors. The change is also inconsistent, as other @backstage dependencies remain on workspace:^.

2. Critical Dependency Downgrade: The version of @backstage/catalog-model is being downgraded from a 1.x version (likely 1.4.1 based on the workspace) to 0.1.1. This is a significant major version downgrade and is almost certain to cause breaking changes and build failures.

3. Incomplete Fix: The PR description warns that yarn.lock was not updated. Without updating the lockfile, these dependency changes will not take effect, and the vulnerabilities will remain.

The recommended approach is to reject this automated PR and address the vulnerabilities manually:

• Identify which workspace packages contain the vulnerable dependencies (ajv and qs).
• Update those transitive dependencies within their respective package.json files.
• Run yarn install to update the yarn.lock file correctly.

I suggest reverting these changes to avoid breaking the application.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/backend-tasks": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/integration": "workspace:^",
    "@backstage/plugin-catalog-node": "workspace:^"

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!