Skip to content

[Snyk] Fix for 2 vulnerabilities #12442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #12442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/catalog-backend-module-gerrit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,14 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-catalog-node": "1.0.0",
Comment on lines +44 to +51
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency updates, while attempting to resolve security vulnerabilities, introduce several critical issues:

  1. Incorrect Version Pinning: Replacing workspace:^ with pinned versions is an anti-pattern in a monorepo using Yarn workspaces. It can lead to multiple versions of the same package being installed, causing type mismatches and other runtime errors. The change is also inconsistent, as other @backstage dependencies remain on workspace:^.

  2. Critical Dependency Downgrade: The version of @backstage/catalog-model is being downgraded from a 1.x version (likely 1.4.1 based on the workspace) to 0.1.1. This is a significant major version downgrade and is almost certain to cause breaking changes and build failures.

  3. Incomplete Fix: The PR description warns that yarn.lock was not updated. Without updating the lockfile, these dependency changes will not take effect, and the vulnerabilities will remain.

The recommended approach is to reject this automated PR and address the vulnerabilities manually:

  • Identify which workspace packages contain the vulnerable dependencies (ajv and qs).
  • Update those transitive dependencies within their respective package.json files.
  • Run yarn install to update the yarn.lock file correctly.

I suggest reverting these changes to avoid breaking the application.

    "@backstage/backend-common": "workspace:^",
    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/backend-tasks": "workspace:^",
    "@backstage/catalog-model": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/integration": "workspace:^",
    "@backstage/plugin-catalog-node": "workspace:^"

"fs-extra": "10.1.0",
"node-fetch": "^2.6.7",
"uuid": "^8.0.0",
Expand Down
Loading