Skip to content

[Snyk] Fix for 2 vulnerabilities #12443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
+2 −2
Closed

[Snyk] Fix for 2 vulnerabilities #12443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/microsoft-calendar/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Comment on lines +44 to +47
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes incorrectly replace workspace-local dependencies (workspace:^) with very old, fixed versions from the public registry. This is a significant downgrade that will likely break the build and cause runtime issues.

  • @backstage/core-components is being downgraded from a workspace version (which appears to be 0.13.4-next.0) to 0.1.0.
  • @backstage/theme is being downgraded from a workspace version (which appears to be 0.4.1) to 0.1.1.

The workspace:^ protocol is essential in this monorepo for using the local, in-development versions of packages. Overriding this with fixed versions from a public registry is incorrect.

The correct approach to fix the underlying vulnerabilities (in ajv and qs) is to update the vulnerable transitive dependencies within the appropriate workspace packages (e.g., update qs in @backstage/core-components/package.json) and then run yarn install to update the lockfile. This PR as it stands should not be merged.

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/theme": "workspace:^"

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@microsoft/microsoft-graph-types": "^2.25.0",
Expand Down
Loading