Skip to content

[Snyk] Fix for 2 vulnerabilities #12444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
+2 −2
Closed

[Snyk] Fix for 2 vulnerabilities #12444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/home/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-home-react": "workspace:^",
"@backstage/plugin-catalog-react": "1.0.0",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Changing workspace:^ to a fixed version 1.0.0 for @backstage/plugin-catalog-react might prevent future automatic updates from the workspace. While this fixes the immediate vulnerability, it could lead to dependency drift if other packages in the monorepo are updated and this one is not. Consider if this package should always be aligned with the workspace version or if a specific version is truly required for the fix.

Suggested change
"@backstage/plugin-catalog-react": "1.0.0",
"@backstage/plugin-catalog-react": "workspace:^",

"@backstage/plugin-home-react": "0.1.0",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the previous comment, fixing @backstage/plugin-home-react to 0.1.0 instead of workspace:^ could introduce challenges in maintaining consistent dependency versions across the monorepo. If the intention is to always use the latest compatible version within the workspace, workspace:^ is generally preferred. If this specific version is critical for the vulnerability fix, ensure this is documented and understood for future maintenance.

Suggested change
"@backstage/plugin-home-react": "0.1.0",
"@backstage/plugin-home-react": "workspace:^",

"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading