Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions plugins/scaffolder/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,24 +50,24 @@
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/errors": "0.1.1",
"@backstage/integration": "workspace:^",
"@backstage/integration-react": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-permission-react": "workspace:^",
"@backstage/plugin-scaffolder-common": "workspace:^",
"@backstage/plugin-scaffolder-react": "workspace:^",
"@backstage/plugin-scaffolder-react": "1.0.0",
"@backstage/theme": "workspace:^",
"@backstage/types": "workspace:^",
"@backstage/types": "0.1.1",
Comment on lines +53 to +62
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This PR incorrectly downgrades several internal @backstage packages (@backstage/errors, @backstage/plugin-scaffolder-react, @backstage/types) by pinning them to old, specific versions instead of using the workspace:^ protocol. This is incorrect for a monorepo setup and will likely break the build. These dependencies should be reverted to use workspace:^ to ensure they use the local, up-to-date versions from the repository.

    "@backstage/errors": "workspace:^",
    "@backstage/integration": "workspace:^",
    "@backstage/integration-react": "workspace:^",
    "@backstage/plugin-catalog-common": "workspace:^",
    "@backstage/plugin-catalog-react": "workspace:^",
    "@backstage/plugin-permission-react": "workspace:^",
    "@backstage/plugin-scaffolder-common": "workspace:^",
    "@backstage/plugin-scaffolder-react": "workspace:^",
    "@backstage/theme": "workspace:^",
    "@backstage/types": "workspace:^"

"@codemirror/language": "^6.0.0",
"@codemirror/legacy-modes": "^6.1.0",
"@codemirror/view": "^6.0.0",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
"@react-hookz/web": "^20.0.0",
"@rjsf/core": "^3.2.1",
"@rjsf/core": "^5.0.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This is a major version upgrade for @rjsf/core from v3 to v5. This is a significant jump and likely includes breaking changes that could affect form rendering in the scaffolder. The automated tool that created this PR may not have accounted for these. It is recommended to review the @rjsf/core v4 and v5 release notes and update the code accordingly to ensure compatibility.

"@rjsf/material-ui": "^3.2.1",
"@rjsf/utils": "5.7.3",
"@rjsf/validator-ajv8": "5.7.3",
Expand All @@ -82,7 +82,7 @@
"json-schema-library": "^7.3.9",
"lodash": "^4.17.21",
"luxon": "^3.0.0",
"qs": "^6.9.4",
"qs": "^6.14.2",
"react-use": "^17.2.4",
"yaml": "^2.0.0",
"zen-observable": "^0.10.0",
Expand Down
Loading