Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/org/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,17 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "1.0.0",
"@backstage/theme": "0.1.1",
Comment on lines +31 to +35
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated change incorrectly pins several @backstage dependencies to specific, and in some cases older, versions, replacing the workspace:^ specifier. This is likely to cause issues in a monorepo environment that uses Yarn workspaces and may not fix the underlying security vulnerabilities.

Specifically:

  • @backstage/catalog-model is pinned to 0.1.1. Based on the provided repository files, the workspace version is 1.4.1. This is a significant downgrade and will likely not fix the ajv vulnerability, which requires an upgrade of ajv to >8.12.0.
  • @backstage/plugin-catalog-react is pinned to 1.0.0.
  • @backstage/theme is pinned to 0.1.1. The workspace version appears to be 0.4.1, so this is also a downgrade.

The workspace:^ protocol is crucial for ensuring that you are using the version of the package from within your monorepo. Replacing it with a fixed version from a public registry will likely break your local development workflow and could introduce unexpected behavior or build failures.

The suggested change reverts these dependencies to use the workspace:^ specifier. To correctly fix the vulnerabilities, you should update the vulnerable transitive dependencies (like ajv) by updating the parent @backstage packages within their own workspaces, and then regenerate the lockfile.

Suggested change
"@backstage/catalog-model": "0.1.1",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "1.0.0",
"@backstage/theme": "0.1.1",
"@backstage/catalog-model": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
"p-limit": "^3.1.0",
"pluralize": "^8.0.0",
"qs": "^6.10.1",
"qs": "^6.14.2",
"react-use": "^17.2.4"
},
"peerDependencies": {
Expand Down
Loading