forked from SDA-SE/backstage
-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Fix for 2 vulnerabilities #12447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+4
−4
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This automated change incorrectly pins several
@backstagedependencies to specific, and in some cases older, versions, replacing theworkspace:^specifier. This is likely to cause issues in a monorepo environment that uses Yarn workspaces and may not fix the underlying security vulnerabilities.Specifically:
@backstage/catalog-modelis pinned to0.1.1. Based on the provided repository files, the workspace version is1.4.1. This is a significant downgrade and will likely not fix theajvvulnerability, which requires an upgrade ofajvto>8.12.0.@backstage/plugin-catalog-reactis pinned to1.0.0.@backstage/themeis pinned to0.1.1. The workspace version appears to be0.4.1, so this is also a downgrade.The
workspace:^protocol is crucial for ensuring that you are using the version of the package from within your monorepo. Replacing it with a fixed version from a public registry will likely break your local development workflow and could introduce unexpected behavior or build failures.The suggested change reverts these dependencies to use the
workspace:^specifier. To correctly fix the vulnerabilities, you should update the vulnerable transitive dependencies (likeajv) by updating the parent@backstagepackages within their own workspaces, and then regenerate the lockfile.