Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/core-app-api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/config": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/types": "workspace:^",
"@backstage/version-bridge": "workspace:^",
"@backstage/version-bridge": "0.1.0",
Comment on lines +35 to +38
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These dependency changes are incorrect and will likely break the application. The workspace:^ protocol is being replaced with pinned, very old versions of these packages. This constitutes a significant downgrade from the versions currently defined in the workspace:

  • @backstage/config would be downgraded from version 1.0.8 to 0.1.1.
  • @backstage/core-plugin-api would be downgraded from version 1.5.3 to 0.1.0.
  • @backstage/version-bridge would be downgraded from version 1.0.4 to 0.1.0.

This change breaks the monorepo's workspace linking and introduces outdated code. To fix the underlying vulnerabilities in transitive dependencies (such as ajv and qs), the recommended approach is to use Yarn's resolutions feature in the root package.json. This allows you to force newer, non-vulnerable versions of those specific packages without altering the versions of your workspace packages.

Please revert these changes and use resolutions instead.

    "@backstage/config": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/types": "workspace:^",
    "@backstage/version-bridge": "workspace:^"

"@types/prop-types": "^15.7.3",
"@types/react": "^16.13.1 || ^17.0.0",
"history": "^5.0.0",
Expand Down
Loading