Skip to content

[Snyk] Fix for 2 vulnerabilities#12450

Closed
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-0e2bbcedab4725d0fb9aca537c7f799a
Closed

[Snyk] Fix for 2 vulnerabilities#12450
q1blue wants to merge 1 commit intomasterfrom
snyk-fix-0e2bbcedab4725d0fb9aca537c7f799a

Conversation

@q1blue
Copy link
Copy Markdown
Collaborator

@q1blue q1blue commented Feb 17, 2026

snyk-top-banner

Snyk has created this PR to fix 2 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • packages/cli/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AJV-15274295
  157  
medium severity Allocation of Resources Without Limits or Throttling
SNYK-JS-QS-15268416
  62  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)
🦉 Allocation of Resources Without Limits or Throttling


EntelligenceAI PR Summary

Updates CLI package dependencies with workspace pinning and third-party version upgrades.

  • Pinned @backstage/config-loader to 0.1.1 and @backstage/release-manifests to 0.0.1 (removed workspace protocol)
  • Major version upgrade: eslint 8.6.0 → 10.0.0 (potential breaking changes)
  • Updated express 4.17.1 → 4.22.0, webpack 5.70.0 → 5.98.0
  • Upgraded webpack plugins: terser-webpack-plugin 5.1.3 → 5.3.11, @pmmmwh/react-refresh-webpack-plugin 0.5.7 → 0.5.15

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Feb 17, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @q1blue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request, automatically generated by Snyk, focuses on enhancing the project's security posture by updating vulnerable yarn dependencies. It resolves two identified security issues, a Regular Expression Denial of Service and an Allocation of Resources Without Limits or Throttling, by bumping several package versions. The primary impact is a more secure and stable dependency tree for the CLI package.

Highlights

  • Security Vulnerability Fixes: Addressed two security vulnerabilities: a high-severity Regular Expression Denial of Service (ReDoS) (SNYK-JS-AJV-15274295) and a medium-severity Allocation of Resources Without Limits or Throttling (SNYK-JS-QS-15268416).
  • Dependency Upgrades: Upgraded several dependencies in packages/cli/package.json, including @backstage/config-loader, @backstage/release-manifests, @pmmmwh/react-refresh-webpack-plugin, eslint, express, terser-webpack-plugin, and webpack to their latest secure versions.
  • Manual Intervention Required: Noted that the yarn.lock file failed to update automatically and requires manual intervention before merging to ensure consistency, especially for zero-installs users.
Changelog
  • packages/cli/package.json
    • Updated @backstage/config-loader from workspace:^ to 0.1.1.
    • Updated @backstage/release-manifests from workspace:^ to 0.0.1.
    • Updated @pmmmwh/react-refresh-webpack-plugin from ^0.5.7 to ^0.5.15.
    • Updated eslint from ^8.6.0 to ^10.0.0.
    • Updated express from ^4.17.1 to ^4.22.0.
    • Updated terser-webpack-plugin from ^5.1.3 to ^5.3.11.
    • Updated webpack from ^5.70.0 to ^5.98.0.
Activity
  • This pull request was automatically created by Snyk to address identified vulnerabilities.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@snyk-io
Copy link
Copy Markdown

snyk-io Bot commented Feb 17, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request, automatically generated by Snyk, aims to fix two vulnerabilities by upgrading several dependencies. While most of the upgrades are minor and seem safe, there are two significant concerns. First, two internal Backstage packages, @backstage/config-loader and @backstage/release-manifests, are being pinned to very old versions, which is a significant downgrade and will likely break the build. This seems to be an error by the automation. Second, eslint is being upgraded by two major versions (v8 to v10), which likely introduces breaking changes that require updates to the ESLint configuration files, which are not included in this PR. These issues should be addressed before merging.

Comment thread packages/cli/package.json
Comment on lines +37 to +41
"@backstage/config-loader": "0.1.1",
"@backstage/errors": "workspace:^",
"@backstage/eslint-plugin": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/release-manifests": "workspace:^",
"@backstage/release-manifests": "0.0.1",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly downgrades @backstage/config-loader and @backstage/release-manifests from workspace-linked versions (workspace:^) to very old, pinned public versions.

  • @backstage/config-loader is downgraded to 0.1.1 from what should be 1.4.0-next.0 in the workspace.
  • @backstage/release-manifests is downgraded to 0.0.1 from 0.0.9 in the workspace.

These significant downgrades will likely cause build failures or runtime issues due to API incompatibilities. This seems to be an error by the Snyk automation. These dependencies should be reverted to use workspace:^ to ensure they use the correct versions from within the monorepo.

Suggested change
"@backstage/config-loader": "0.1.1",
"@backstage/errors": "workspace:^",
"@backstage/eslint-plugin": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/release-manifests": "workspace:^",
"@backstage/release-manifests": "0.0.1",
"@backstage/config-loader": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/eslint-plugin": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/release-manifests": "workspace:^",

Comment thread packages/cli/package.json
"esbuild": "^0.18.0",
"esbuild-loader": "^2.18.0",
"eslint": "^8.6.0",
"eslint": "^10.0.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This PR upgrades eslint from v8 to v10. This is a major version bump which can introduce breaking changes. The ESLint configuration files in this repository (e.g., in packages/cli/config/) have not been updated as part of this PR. It's important to verify that the existing ESLint configuration is compatible with ESLint v10 and update it if necessary. Please check the ESLint migration guides for v9 and v10 for any required changes before merging.

@entelligence-ai-pr-reviews
Copy link
Copy Markdown

Walkthrough

This PR updates dependency versions in the CLI package, focusing on both workspace and third-party dependencies. Two internal Backstage workspace dependencies are pinned to specific versions instead of using the workspace protocol. Multiple third-party dependencies receive version upgrades, including build tools and development utilities. The most significant change is a major version upgrade of ESLint from v8.6.0 to v10.0.0, which may introduce breaking changes and require code adjustments. Other notable upgrades include webpack, express, and various webpack plugins, bringing security patches and performance improvements.

Changes

File(s) Summary
packages/cli/package.json Updated multiple dependencies: pinned workspace dependencies (@backstage/config-loader to 0.1.1, @backstage/release-manifests to 0.0.1); upgraded third-party dependencies including eslint (8.6.0 → 10.0.0 - major version), express (4.17.1 → 4.22.0), webpack (5.70.0 → 5.98.0), terser-webpack-plugin (5.1.3 → 5.3.11), and @pmmmwh/react-refresh-webpack-plugin (0.5.7 → 0.5.15).

▶️AI Code Reviews for VS Code, Cursor, Windsurf
Install the extension

Note for Windsurf Please change the default marketplace provider to the following in the windsurf settings:

Marketplace Extension Gallery Service URL: https://marketplace.visualstudio.com/_apis/public/gallery

Marketplace Gallery Item URL: https://marketplace.visualstudio.com/items

Entelligence.ai can learn from your feedback. Simply add 👍 / 👎 emojis to teach it your preferences. More shortcuts below

Emoji Descriptions:

  • ⚠️ Potential Issue - May require further investigation.
  • 🔒 Security Vulnerability - Fix to ensure system safety.
  • 💻 Code Improvement - Suggestions to enhance code quality.
  • 🔨 Refactor Suggestion - Recommendations for restructuring code.
  • ℹ️ Others - General comments and information.

Interact with the Bot:

  • Send a message or request using the format:
    @entelligenceai + *your message*
Example: @entelligenceai Can you suggest improvements for this code?
  • Help the Bot learn by providing feedback on its responses.
    @entelligenceai + *feedback*
Example: @entelligenceai Do not comment on `save_auth` function !

Also you can trigger various commands with the bot by doing
@entelligenceai command

The current supported commands are

  1. config - shows the current config
  2. retrigger_review - retriggers the review

More commands to be added soon.

@github-actions
Copy link
Copy Markdown

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Feb 24, 2026
@github-actions github-actions Bot closed this Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants