Skip to content

[Snyk] Fix for 2 vulnerabilities #12450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
+7 −7
Closed

[Snyk] Fix for 2 vulnerabilities #12450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,19 +34,19 @@
"@backstage/cli-common": "workspace:^",
"@backstage/cli-node": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config-loader": "workspace:^",
"@backstage/config-loader": "0.1.1",
"@backstage/errors": "workspace:^",
"@backstage/eslint-plugin": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/release-manifests": "workspace:^",
"@backstage/release-manifests": "0.0.1",
Comment on lines +37 to +41
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly downgrades @backstage/config-loader and @backstage/release-manifests from workspace-linked versions (workspace:^) to very old, pinned public versions.

  • @backstage/config-loader is downgraded to 0.1.1 from what should be 1.4.0-next.0 in the workspace.
  • @backstage/release-manifests is downgraded to 0.0.1 from 0.0.9 in the workspace.

These significant downgrades will likely cause build failures or runtime issues due to API incompatibilities. This seems to be an error by the Snyk automation. These dependencies should be reverted to use workspace:^ to ensure they use the correct versions from within the monorepo.

Suggested change
"@backstage/config-loader": "0.1.1",
"@backstage/errors": "workspace:^",
"@backstage/eslint-plugin": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/release-manifests": "workspace:^",
"@backstage/release-manifests": "0.0.1",
"@backstage/config-loader": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/eslint-plugin": "workspace:^",
"@backstage/integration": "workspace:^",
"@backstage/release-manifests": "workspace:^",

"@backstage/types": "workspace:^",
"@esbuild-kit/cjs-loader": "^2.4.1",
"@manypkg/get-packages": "^1.1.3",
"@octokit/graphql": "^5.0.0",
"@octokit/graphql-schema": "^13.7.0",
"@octokit/oauth-app": "^4.2.0",
"@octokit/request": "^6.0.0",
"@pmmmwh/react-refresh-webpack-plugin": "^0.5.7",
"@pmmmwh/react-refresh-webpack-plugin": "^0.5.15",
"@rollup/plugin-commonjs": "^23.0.0",
"@rollup/plugin-json": "^5.0.0",
"@rollup/plugin-node-resolve": "^13.0.6",
Expand Down Expand Up @@ -80,7 +80,7 @@
"diff": "^5.0.0",
"esbuild": "^0.18.0",
"esbuild-loader": "^2.18.0",
"eslint": "^8.6.0",
"eslint": "^10.0.0",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This PR upgrades eslint from v8 to v10. This is a major version bump which can introduce breaking changes. The ESLint configuration files in this repository (e.g., in packages/cli/config/) have not been updated as part of this PR. It's important to verify that the existing ESLint configuration is compatible with ESLint v10 and update it if necessary. Please check the ESLint migration guides for v9 and v10 for any required changes before merging.

"eslint-config-prettier": "^8.3.0",
"eslint-formatter-friendly": "^7.0.0",
"eslint-plugin-deprecation": "^1.3.2",
Expand All @@ -90,7 +90,7 @@
"eslint-plugin-react": "^7.28.0",
"eslint-plugin-react-hooks": "^4.3.0",
"eslint-webpack-plugin": "^3.1.1",
"express": "^4.17.1",
"express": "^4.22.0",
"fork-ts-checker-webpack-plugin": "^7.0.0-alpha.8",
"fs-extra": "10.1.0",
"git-url-parse": "^13.0.0",
Expand Down Expand Up @@ -128,9 +128,9 @@
"sucrase": "^3.20.2",
"swc-loader": "^0.2.3",
"tar": "^6.1.12",
"terser-webpack-plugin": "^5.1.3",
"terser-webpack-plugin": "^5.3.11",
"util": "^0.12.3",
"webpack": "^5.70.0",
"webpack": "^5.98.0",
"webpack-dev-server": "^4.7.3",
"webpack-node-externals": "^3.0.0",
"yaml": "^2.0.0",
Expand Down
Loading