Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/events-backend-module-gitlab/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/plugin-events-node": "workspace:^",
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/config": "0.1.1",
"@backstage/plugin-events-node": "0.2.9",
Comment on lines +38 to +40
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Pinning dependencies to specific versions here breaks the Yarn workspaces convention used in this monorepo. Packages within the workspace should reference each other using workspace:^ to ensure a single version of each package is used across the project. Hardcoding versions can lead to version conflicts, increased bundle sizes, and subtle runtime bugs.

The Snyk PR description itself notes that it Failed to update the yarn.lock, which indicates this automated fix is incomplete.

The correct approach to fix the underlying vulnerabilities is to update the dependencies at the root of the monorepo and then run yarn to update the yarn.lock file. These lines should be reverted to use workspace:^.

    "@backstage/backend-plugin-api": "workspace:^",
    "@backstage/config": "workspace:^",
    "@backstage/plugin-events-node": "workspace:^"

"winston": "^3.2.1"
},
"devDependencies": {
Expand Down
Loading