Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/analytics-module-newrelic-browser/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
},
"dependencies": {
"@backstage/config": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change incorrectly modifies the dependency on @backstage/core-components. It replaces the workspace-aware version workspace:^ with a hardcoded, old version 0.1.0. In a monorepo using Yarn workspaces, this is problematic for several reasons:

  • Breaks Workspace Linking: It will cause this package to download @backstage/core-components from the npm registry instead of using the local version from the workspace. This defeats the purpose of a monorepo and can lead to inconsistencies.
  • Significant Downgrade: The version of @backstage/core-components in this repository is 0.13.4-next.0. Changing this to 0.1.0 is a major downgrade and will almost certainly cause build failures or runtime errors.
  • Incorrect Vulnerability Fix: While the intent is to fix a security vulnerability, this approach is incorrect. The vulnerability lies within @backstage/core-components or its dependencies, and should be fixed there, not by changing how a consumer package depends on it.

The fact that Snyk failed to update yarn.lock further indicates that this change is invalid. This PR should be rejected, and the vulnerabilities should be addressed by updating the dependencies within the @backstage/core-components package itself.

Suggested change
"@backstage/core-components": "0.1.0",
"@backstage/core-components": "workspace:^",

"@backstage/core-plugin-api": "workspace:^",
"@newrelic/browser-agent": "^1.236.0",
"react-use": "^17.2.4"
Expand Down
Loading