forked from SDA-SE/backstage
-
Notifications
You must be signed in to change notification settings - Fork 1
[Snyk] Security upgrade @backstage/core-components from 0.0.0-use.local to 0.1.0 #12452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change incorrectly modifies the dependency on
@backstage/core-components. It replaces the workspace-aware versionworkspace:^with a hardcoded, old version0.1.0. In a monorepo using Yarn workspaces, this is problematic for several reasons:@backstage/core-componentsfrom the npm registry instead of using the local version from the workspace. This defeats the purpose of a monorepo and can lead to inconsistencies.@backstage/core-componentsin this repository is0.13.4-next.0. Changing this to0.1.0is a major downgrade and will almost certainly cause build failures or runtime errors.@backstage/core-componentsor its dependencies, and should be fixed there, not by changing how a consumer package depends on it.The fact that Snyk failed to update
yarn.lockfurther indicates that this change is invalid. This PR should be rejected, and the vulnerabilities should be addressed by updating the dependencies within the@backstage/core-componentspackage itself.