Skip to content

[Snyk] Fix for 2 vulnerabilities #12454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
+4 −4
Closed

[Snyk] Fix for 2 vulnerabilities #12454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/dev-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@
},
"dependencies": {
"@backstage/app-defaults": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/core-app-api": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/integration-react": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/integration-react": "0.1.1",
"@backstage/plugin-catalog-react": "1.0.0",
Comment on lines +36 to +41
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated change incorrectly attempts to fix vulnerabilities by pinning workspace dependencies to old, fixed versions. This will likely break the project.

Issues:

  • Breaks Yarn Workspaces: Replacing workspace:^ with fixed versions defeats the purpose of a monorepo setup, causing packages to use outdated, published code instead of local, up-to-date sources.
  • Major Downgrades: The pinned versions are significant downgrades (e.g., @backstage/catalog-model from 1.4.1 to 0.1.1), which will almost certainly cause breaking changes.
  • Incorrect Fix Strategy: The vulnerabilities are in transitive dependencies (ajv and qs). The fix should be to update these dependencies in their own packages (packages/catalog-model/package.json and packages/core-components/package.json), not to alter the dependencies of @backstage/dev-utils.

I'm suggesting to revert these changes. The vulnerabilities should be addressed by updating the underlying dependencies directly in their respective packages.

    "@backstage/catalog-model": "workspace:^",
    "@backstage/core-app-api": "workspace:^",
    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/integration-react": "workspace:^",
    "@backstage/plugin-catalog-react": "workspace:^"

"@backstage/test-utils": "workspace:^",
"@backstage/theme": "workspace:^",
"@material-ui/core": "^4.12.2",
Expand Down
Loading