Skip to content

[Snyk] Fix for 2 vulnerabilities #12455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #12455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/proxy-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Pinning @backstage/backend-common to a specific version (0.24.1) instead of using the workspace version (workspace:^, which resolves to 0.19.2-next.0) can lead to issues. It may introduce multiple versions of the package and its dependencies, and can cause type incompatibilities with other packages that rely on the workspace version. While this might be a temporary fix for a vulnerability, the better long-term solution in a monorepo is to upgrade the version of @backstage/backend-common across the entire workspace.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/backend-common": "workspace:^",

"@backstage/backend-plugin-api": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/config": "0.1.1",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change downgrades @backstage/config from the workspace version (1.0.8) to 0.1.1. This is a major downgrade and is very likely to cause build failures or runtime errors due to API incompatibilities. Other packages like @backstage/backend-plugin-api still depend on the workspace version of @backstage/config, which will lead to type conflicts. This change seems incorrect and should be reverted. The PR description's warning about yarn.lock failing to update is probably caused by this invalid dependency resolution.

Suggested change
"@backstage/config": "0.1.1",
"@backstage/config": "workspace:^",

"@types/express": "^4.17.6",
"express": "^4.17.1",
"express": "^4.22.0",
"express-promise-router": "^4.1.0",
"http-proxy-middleware": "^2.0.0",
"morgan": "^1.10.0",
Expand Down
Loading