Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/tech-radar/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Comment on lines +35 to +37
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes incorrectly replace workspace:^ with fixed versions for internal packages. In a monorepo using Yarn workspaces, workspace:^ ensures that you are using the latest code from other packages within the same repository. Pinning to a specific published version breaks this, and can lead to using outdated code from the registry instead of the local source, which will likely break local development and testing.

The correct way to fix the underlying security vulnerabilities is to update the vulnerable dependencies in their respective source packages. For example, the qs vulnerability should be fixed by updating the qs dependency in @backstage/core-components/package.json.

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/theme": "workspace:^"

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading