Skip to content

[Snyk] Fix for 2 vulnerabilities #12457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
+2 −2
Closed

[Snyk] Fix for 2 vulnerabilities #12457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/catalog-customized/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/plugin-catalog": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^"
"@backstage/plugin-catalog": "0.1.1",
"@backstage/plugin-catalog-react": "0.0.1"
Comment on lines +36 to +37
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated change from Snyk is incorrect and will likely break the project.

  1. Breaks Workspace Linking: It replaces workspace:^ with pinned versions. This breaks the yarn workspace convention of linking to local packages within the monorepo.
  2. Major Downgrade: The versions being pinned (0.1.1 and 0.0.1) are extremely old. The current versions of these packages in the workspace are @backstage/plugin-catalog@1.12.1-next.0 and @backstage/plugin-catalog-react@1.8.1-next.0. This massive downgrade will almost certainly lead to compilation errors or runtime failures.
  3. Incorrect Vulnerability Fix: While the intent is to fix vulnerabilities in transitive dependencies (ajv and qs), this is not the right way to do it in this project. A better approach would be to address the vulnerabilities directly, for example by using resolutions in the root package.json file to enforce secure versions of ajv and qs across the entire workspace.

I suggest rejecting this change and fixing the vulnerabilities manually. You should revert these changes and investigate a proper fix.

Suggested change
"@backstage/plugin-catalog": "0.1.1",
"@backstage/plugin-catalog-react": "0.0.1"
"@backstage/plugin-catalog": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^"

},
"devDependencies": {
"@types/react": "^16.13.1 || ^17.0.0"
Expand Down
Loading