Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/gcp-projects/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/core-components": "workspace:^",
"@backstage/core-components": "0.1.0",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/theme": "0.1.1",
Comment on lines +36 to +38
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These changes incorrectly downgrade @backstage/core-components and @backstage/theme to very old versions, which will likely break the plugin. The workspace:^ protocol, which links to local packages in the monorepo, is being replaced with pinned versions 0.1.0 and 0.1.1. This is a significant downgrade from the versions available in the workspace (e.g., @backstage/core-components is at 0.13.4-next.0).

This automated change is likely a mistake caused by misinterpreting the workspace: protocol. The correct fix for the security vulnerabilities is to update the yarn.lock file to use newer versions of the transitive dependencies, not to downgrade these core packages. The PR description even warns that updating yarn.lock failed.

    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/theme": "workspace:^"

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading