Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/ilert/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "1.0.0",
"@backstage/theme": "0.1.1",
Comment on lines +26 to +31
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This automated change incorrectly downgrades several @backstage dependencies to very old versions instead of using the versions from the workspace. For example, @backstage/catalog-model is being downgraded from the workspace version (which is 1.4.1) to 0.1.1. This is a critical issue that will likely break the build and introduce many other problems.

The workspace:^ protocol should be maintained to ensure consistency within the monorepo. The underlying vulnerabilities in transitive dependencies should be addressed at the repository root, for example by using resolutions in the root package.json to force newer, non-vulnerable versions of the affected packages (ajv, qs).

I suggest reverting these changes.

    "@backstage/catalog-model": "workspace:^",
    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-catalog-react": "workspace:^",
    "@backstage/theme": "workspace:^"

"@date-io/luxon": "1.x",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading