Skip to content

[Snyk] Fix for 2 vulnerabilities #12462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #12462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/gocd/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,18 +29,18 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "1.0.0",
"@backstage/theme": "0.1.1",
Comment on lines +32 to +37
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The changes to the @backstage/* dependencies are incorrect. Changing them from workspace:^ to fixed, older versions will likely break the build or cause runtime issues in this monorepo. The workspace: protocol is essential for linking local packages in a yarn workspace.

For example, @backstage/catalog-model is being downgraded from the workspace version (which is 1.4.1) to 0.1.1. This is a significant downgrade that will cause API incompatibilities.

The automated Snyk fix seems to have incorrectly resolved dependencies to address the ajv vulnerability. The correct approach is to rely on the workspace version, which should have its own dependencies managed correctly.

I recommend reverting these specific changes to use workspace:^.

    "@backstage/catalog-model": "workspace:^",
    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/errors": "workspace:^",
    "@backstage/plugin-catalog-react": "workspace:^",
    "@backstage/theme": "workspace:^"

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
"lodash": "^4.17.21",
"luxon": "^3.0.0",
"qs": "^6.10.1",
"qs": "^6.14.2",
"react-use": "^17.2.4"
},
"peerDependencies": {
Expand Down
Loading