Skip to content

[Snyk] Fix for 2 vulnerabilities #12463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
+5 −5
Closed

[Snyk] Fix for 2 vulnerabilities #12463

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions plugins/example-todo-list-backend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "0.6.19",
Comment on lines +27 to +28
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Replacing workspace:^ with pinned versions is an anti-pattern in a Yarn workspace monorepo. It will cause this package to use versions from the npm registry instead of the local packages, leading to version inconsistencies and potential build failures. Please revert to using workspace:^.

To address the underlying security vulnerability, consider using Yarn's resolutions feature in the root package.json to force a specific, secure version of the vulnerable transitive dependency across the entire workspace.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "0.6.19",
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",

"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",
"@backstage/errors": "0.1.1",
"@backstage/plugin-auth-node": "0.6.0",
Comment on lines +30 to +31
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Replacing workspace:^ with pinned versions is an anti-pattern in a Yarn workspace monorepo. It will cause this package to use versions from the npm registry instead of the local packages, leading to version inconsistencies and potential build failures. For example, @backstage/errors is being pinned to 0.1.1, which appears to be a significant downgrade from the version in the workspace (1.2.1). Please revert to using workspace:^.

To address the underlying security vulnerability, consider using Yarn's resolutions feature in the root package.json.

Suggested change
"@backstage/errors": "0.1.1",
"@backstage/plugin-auth-node": "0.6.0",
"@backstage/errors": "workspace:^",
"@backstage/plugin-auth-node": "workspace:^",

"@types/express": "^4.17.6",
"express": "^4.17.1",
"express": "^4.22.0",
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The version 4.22.0 for express does not exist in the npm registry. The latest version in the 4.x line is 4.19.2. This will cause the dependency installation to fail. Please correct the version to a valid one that resolves the security vulnerability.

Suggested change
"express": "^4.22.0",
"express": "^4.19.2",

"express-promise-router": "^4.1.0",
"uuid": "^8.3.2",
"winston": "^3.2.1",
Expand Down
Loading