Skip to content

[Snyk] Fix for 2 vulnerabilities #12464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
q1blue wants to merge 1 commit into from
Closed

[Snyk] Fix for 2 vulnerabilities #12464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/sonarqube/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,12 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/plugin-sonarqube-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "1.0.0",
"@backstage/plugin-sonarqube-react": "0.1.0",
"@backstage/theme": "0.1.1",
Comment on lines +38 to +43
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

These automated changes from Snyk are incorrect and will likely break the application. They should be reverted.

  1. Breaking Monorepo Structure: Replacing "workspace:^" with pinned versions breaks the yarn workspace linking for these packages. This means local changes in these packages will no longer be reflected, and it will instead use outdated, published versions.
  2. Significant Downgrades: The pinned versions are major downgrades from the current versions in the workspace. For example, @backstage/catalog-model is being downgraded from its workspace version 1.4.1 to 0.1.1. This will almost certainly lead to build failures or runtime errors due to API incompatibilities.

The correct way to fix the underlying vulnerabilities (in ajv and qs) is to either:

  • Update the vulnerable packages directly in the package.json where they are defined as dependencies (e.g., update ajv in packages/catalog-model/package.json).
  • Use yarn's resolutions feature in the root package.json to force a non-vulnerable version of the transitive dependencies across the entire workspace.

Additionally, as noted in the PR description, the yarn.lock file was not updated, which is another critical issue that would prevent these changes from working correctly even if they were valid.

    "@backstage/catalog-model": "workspace:^",
    "@backstage/core-components": "workspace:^",
    "@backstage/core-plugin-api": "workspace:^",
    "@backstage/plugin-catalog-react": "workspace:^",
    "@backstage/plugin-sonarqube-react": "workspace:^",
    "@backstage/theme": "workspace:^"

"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
"@material-ui/lab": "4.0.0-alpha.61",
Expand Down
Loading