-
Notifications
You must be signed in to change notification settings - Fork 1
Replace dependency @material-ui/core with @mui/material ^5.0.0 #12483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -76,7 +76,7 @@ | |
| "@backstage/plugin-user-settings": "workspace:^", | ||
| "@backstage/theme": "workspace:^", | ||
| "@internal/plugin-catalog-customized": "workspace:^", | ||
| "@material-ui/core": "^4.12.2", | ||
| "@mui/material": "^5.0.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This package still depends on Severity: high 🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage. |
||
| "@material-ui/icons": "^4.9.1", | ||
| "@material-ui/lab": "4.0.0-alpha.61", | ||
| "@octokit/rest": "^19.0.3", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,7 +39,7 @@ | |
| "@backstage/version-bridge": "workspace:^", | ||
| "@date-io/core": "^1.3.13", | ||
| "@material-table/core": "^3.1.0", | ||
| "@material-ui/core": "^4.12.2", | ||
| "@mui/material": "^5.0.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Severity: medium 🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage. |
||
| "@material-ui/icons": "^4.9.1", | ||
| "@material-ui/lab": "4.0.0-alpha.61", | ||
| "@react-hookz/web": "^20.0.0", | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -37,7 +37,7 @@ | |
| "@mui/material": "^5.12.2" | ||
| }, | ||
| "peerDependencies": { | ||
| "@material-ui/core": "^4.12.2", | ||
| "@mui/material": "^5.0.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The repo templates (e.g. Severity: medium 🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage. |
||
| "@types/react": "^16.13.1 || ^17.0.0", | ||
| "react": "^16.13.1 || ^17.0.0", | ||
| "react-dom": "^16.13.1 || ^17.0.0" | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mui/materialis added here, but this workspace still has source imports from@material-ui/core(e.g.packages/app-defaults/src/defaults/components.tsx); with Yarn PnP this will likely break builds since@material-ui/coreis no longer a declared dependency for the package.Severity: high
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.