-
Notifications
You must be signed in to change notification settings - Fork 1
Replace dependency @material-ui/icons with @mui/icons-material ^5.0.0 #12486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -40,7 +40,7 @@ | |
| "@date-io/core": "^1.3.13", | ||
| "@material-table/core": "^3.1.0", | ||
| "@material-ui/core": "^4.12.2", | ||
| "@material-ui/icons": "^4.9.1", | ||
| "@mui/icons-material": "^5.0.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Severity: medium 🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage. |
||
| "@material-ui/lab": "4.0.0-alpha.61", | ||
| "@react-hookz/web": "^20.0.0", | ||
| "@types/react": "^16.13.1 || ^17.0.0", | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This switches the dependency to
@mui/icons-material, but the repo still imports icons from@material-ui/icons/...(e.g.packages/app-defaults/src/defaults/icons.tsx,packages/app/src/components/Root/Root.tsx), which will become a missing module unless imports/aliasing are updated.Severity: high
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.