Skip to content

[Snyk] Fix for 1 vulnerabilities #4337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #4337

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugins/catalog-backend-module-ldap/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/backend-tasks": "0.6.1",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/plugin-catalog-node": "1.0.0",
Comment on lines +35 to +40
Copy link
Copy Markdown

@graphite-app graphite-app Bot Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version numbers specified in this PR appear problematic and may introduce compatibility issues:

  1. The versions being introduced (catalog-model@0.1.1, plugin-catalog-common@0.1.0) seem to be extremely old, while plugin-catalog-node is set to 1.0.0.

  2. These packages are typically interdependent, and such version mismatches could cause runtime errors or unexpected behavior.

  3. The PR description notes a failure to update the yarn.lock file, which is a red flag that these dependency changes haven't been properly resolved.

Before merging, it would be advisable to:

  • Verify these are the correct target versions for addressing the vulnerability
  • Ensure all interdependent packages are updated to compatible versions
  • Successfully update the yarn.lock file to confirm dependency resolution
Suggested change
"@backstage/backend-tasks": "0.6.1",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/plugin-catalog-node": "1.0.0",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/types": "workspace:^",
"@types/ldapjs": "^2.2.0",
"ldapjs": "^2.2.0",
Expand Down
Loading