[Snyk] Fix for 1 vulnerabilities#4340
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TARFS-9535930
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews. |
Reviewer's Guide by SourceryThis pull request updates the versions of Updated class diagram for package.json dependenciesclassDiagram
class PackageJson {
dependencies
}
PackageJson -- "0.0.0-use.local" CoreAppApi
PackageJson -- "0.0.0-use.local" PluginCatalogReact
PackageJson -- "0.0.0-use.local" Theme
PackageJson -- "0.1.0" CoreAppApiUpdated
PackageJson -- "0.0.1" PluginCatalogReactUpdated
PackageJson -- "0.1.1" ThemeUpdated
class CoreAppApi {
version: string
}
note for CoreAppApi "Old version"
class PluginCatalogReact {
version: string
}
note for PluginCatalogReact "Old version"
class Theme {
version: string
}
note for Theme "Old version"
class CoreAppApiUpdated {
version: string
}
note for CoreAppApiUpdated "New version"
class PluginCatalogReactUpdated {
version: string
}
note for PluginCatalogReactUpdated "New version"
class ThemeUpdated {
version: string
}
note for ThemeUpdated "New version"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We have skipped reviewing this pull request. Here's why:
- It seems to have been created by a bot (hey, snyk-io[bot]!). We assume it knows what it's doing!
- It seems to have been created by a bot ('[Snyk]' found in title). We assume it knows what it's doing!
- We don't review packaging changes - Let us know if you'd like us to change this.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| "@backstage/core-app-api": "0.1.0", | ||
| "@backstage/core-components": "workspace:^", | ||
| "@backstage/core-plugin-api": "workspace:^", | ||
| "@backstage/errors": "workspace:^", | ||
| "@backstage/plugin-catalog-react": "workspace:^", | ||
| "@backstage/theme": "workspace:^", | ||
| "@backstage/plugin-catalog-react": "0.0.1", | ||
| "@backstage/theme": "0.1.1", |
There was a problem hiding this comment.
This PR replaces workspace references (workspace:^) with fixed versions that appear to be quite outdated (0.1.0, 0.0.1, 0.1.1). In a Yarn workspace setup, this approach is problematic as it:
- Breaks the workspace linking mechanism that ensures compatible versions
- Introduces potentially incompatible package versions
- May not properly address the underlying vulnerability
Additionally, the PR description notes that the yarn.lock update failed, which is a red flag.
A better approach would be to:
- Maintain the workspace references (
workspace:^) - Address the vulnerability by updating the affected dependency in a way that preserves workspace integrity
- Ensure the yarn.lock file is properly updated
Consider rejecting this PR and requesting a solution that doesn't compromise the workspace structure while still addressing the security vulnerability.
| "@backstage/core-app-api": "0.1.0", | |
| "@backstage/core-components": "workspace:^", | |
| "@backstage/core-plugin-api": "workspace:^", | |
| "@backstage/errors": "workspace:^", | |
| "@backstage/plugin-catalog-react": "workspace:^", | |
| "@backstage/theme": "workspace:^", | |
| "@backstage/plugin-catalog-react": "0.0.1", | |
| "@backstage/theme": "0.1.1", | |
| "@backstage/core-app-api": "workspace:^", | |
| "@backstage/core-components": "workspace:^", | |
| "@backstage/core-plugin-api": "workspace:^", | |
| "@backstage/errors": "workspace:^", | |
| "@backstage/plugin-catalog-react": "workspace:^", | |
| "@backstage/theme": "workspace:^", |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
|
Report too large to display inline |
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is a critical CVE?Contains a Critical Common Vulnerability and Exposure (CVE). Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/user-settings/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TARFS-9535930
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.
Summary by Sourcery
Update package dependencies to resolve a high-severity security vulnerability in the user-settings plugin
Bug Fixes:
Enhancements: