Skip to content

[Snyk] Fix for 1 vulnerabilities #4340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #4340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions plugins/user-settings/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,12 @@
"clean": "backstage-cli package clean"
},
"dependencies": {
"@backstage/core-app-api": "workspace:^",
"@backstage/core-app-api": "0.1.0",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/theme": "0.1.1",
Comment on lines +35 to +40
Copy link
Copy Markdown

@graphite-app graphite-app Bot Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR replaces workspace references (workspace:^) with fixed versions that appear to be quite outdated (0.1.0, 0.0.1, 0.1.1). In a Yarn workspace setup, this approach is problematic as it:

  1. Breaks the workspace linking mechanism that ensures compatible versions
  2. Introduces potentially incompatible package versions
  3. May not properly address the underlying vulnerability

Additionally, the PR description notes that the yarn.lock update failed, which is a red flag.

A better approach would be to:

  • Maintain the workspace references (workspace:^)
  • Address the vulnerability by updating the affected dependency in a way that preserves workspace integrity
  • Ensure the yarn.lock file is properly updated

Consider rejecting this PR and requesting a solution that doesn't compromise the workspace structure while still addressing the security vulnerability.

Suggested change
"@backstage/core-app-api": "0.1.0",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",
"@backstage/plugin-catalog-react": "0.0.1",
"@backstage/theme": "0.1.1",
"@backstage/core-app-api": "workspace:^",
"@backstage/core-components": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-react": "workspace:^",
"@backstage/theme": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/types": "workspace:^",
"@material-ui/core": "^4.12.2",
"@material-ui/icons": "^4.9.1",
Expand Down
Loading