Skip to content

[Snyk] Fix for 1 vulnerabilities#4380

Closed
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-b1510a4d4ac45d9a361432264f143552
Closed

[Snyk] Fix for 1 vulnerabilities#4380
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-b1510a4d4ac45d9a361432264f143552

Conversation

@snyk-io
Copy link
Copy Markdown

@snyk-io snyk-io Bot commented Mar 28, 2025

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • packages/core-plugin-api/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Symlink Attack
SNYK-JS-TARFS-9535930
  721  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Summary by Sourcery

Address a high-severity security vulnerability in the project's dependencies by updating package versions

Bug Fixes:

  • Fix a high-severity Symlink Attack vulnerability (SNYK-JS-TARFS-9535930) by updating package dependencies

Enhancements:

  • Update @backstage/config from workspace version to 0.1.1
  • Update @backstage/version-bridge from workspace version to 0.1.0

@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Mar 28, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@restack-app
Copy link
Copy Markdown

restack-app Bot commented Mar 28, 2025

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Mar 28, 2025

Reviewer's Guide by Sourcery

This pull request addresses a high-severity vulnerability by updating specific dependencies in the package.json file of the core-plugin-api package. The changes involve upgrading the @backstage/config and @backstage/version-bridge dependencies to specific versions to mitigate the vulnerability.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated dependencies to fix a high-severity vulnerability.
  • Changed the version of @backstage/config from workspace:^ to 0.1.1.
  • Changed the version of @backstage/version-bridge from workspace:^ to 0.1.0.
packages/core-plugin-api/package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. Here's why:

  • It seems to have been created by a bot (hey, snyk-io[bot]!). We assume it knows what it's doing!
  • It seems to have been created by a bot ('[Snyk]' found in title). We assume it knows what it's doing!
  • We don't review packaging changes - Let us know if you'd like us to change this.

Comment on lines +48 to +50
"@backstage/config": "0.1.1",
"@backstage/types": "workspace:^",
"@backstage/version-bridge": "workspace:^",
"@backstage/version-bridge": "0.1.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change from workspace dependencies to fixed versions (0.1.1 and 0.1.0) could disrupt the monorepo structure. The PR description notes that the yarn.lock file failed to update, which is concerning.

Before merging:

  1. Verify that these specific versions are compatible with the rest of the codebase
  2. Manually update the yarn.lock file as mentioned in the PR description
  3. Consider whether pinning these dependencies to exact versions instead of using workspace references is the right approach for addressing the vulnerability

The Snyk fix is targeting a legitimate security issue (tar-fs symlink attack), but the implementation approach may need adjustment to maintain proper monorepo dependency management.

Suggested change
"@backstage/config": "0.1.1",
"@backstage/types": "workspace:^",
"@backstage/version-bridge": "workspace:^",
"@backstage/version-bridge": "0.1.0",
"@backstage/config": "workspace:^",
"@backstage/types": "workspace:^",
"@backstage/version-bridge": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@socket-security
Copy link
Copy Markdown

Report too large to display inline

View full report↗︎

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 4, 2025

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Apr 4, 2025
@github-actions github-actions Bot closed this Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants