Skip to content

[Snyk] Fix for 1 vulnerabilities #4380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #4380

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/core-plugin-api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/config": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/types": "workspace:^",
"@backstage/version-bridge": "workspace:^",
"@backstage/version-bridge": "0.1.0",
Comment on lines +48 to +50
Copy link
Copy Markdown

@graphite-app graphite-app Bot Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change from workspace dependencies to fixed versions (0.1.1 and 0.1.0) could disrupt the monorepo structure. The PR description notes that the yarn.lock file failed to update, which is concerning.

Before merging:

  1. Verify that these specific versions are compatible with the rest of the codebase
  2. Manually update the yarn.lock file as mentioned in the PR description
  3. Consider whether pinning these dependencies to exact versions instead of using workspace references is the right approach for addressing the vulnerability

The Snyk fix is targeting a legitimate security issue (tar-fs symlink attack), but the implementation approach may need adjustment to maintain proper monorepo dependency management.

Suggested change
"@backstage/config": "0.1.1",
"@backstage/types": "workspace:^",
"@backstage/version-bridge": "workspace:^",
"@backstage/version-bridge": "0.1.0",
"@backstage/config": "workspace:^",
"@backstage/types": "workspace:^",
"@backstage/version-bridge": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@types/react": "^16.13.1 || ^17.0.0",
"history": "^5.0.0",
"prop-types": "^15.7.2",
Expand Down
Loading