Skip to content

[Snyk] Fix for 1 vulnerabilities #4421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #4421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/test-utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@
"start": "backstage-cli package start"
},
"dependencies": {
"@backstage/config": "workspace:^",
"@backstage/config": "0.1.1",
"@backstage/core-app-api": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-react": "workspace:^",
"@backstage/plugin-permission-react": "0.1.0",
Comment on lines +48 to +52
Copy link
Copy Markdown

@graphite-app graphite-app Bot Mar 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces workspace references with fixed version numbers, which disrupts the monorepo's dependency management approach. Using specific published versions (0.1.1, 0.1.0) instead of workspace references (workspace:^) breaks the local development workflow where packages reference each other directly.

The PR description also notes that the yarn.lock file failed to update properly, which is a red flag for compatibility issues.

For monorepo maintenance, it's recommended to:

  1. Keep the workspace references intact
  2. Address the vulnerability through other means, such as updating the affected transitive dependency
  3. Ensure yarn.lock updates correctly before merging

This approach would fix the security vulnerability without compromising the monorepo structure.

Suggested change
"@backstage/config": "0.1.1",
"@backstage/core-app-api": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/core-plugin-api": "0.1.0",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-react": "workspace:^",
"@backstage/plugin-permission-react": "0.1.0",
"@backstage/config": "workspace:^",
"@backstage/core-app-api": "workspace:^",
"@backstage/core-plugin-api": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
"@backstage/plugin-permission-react": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/theme": "workspace:^",
"@backstage/types": "workspace:^",
"@material-ui/core": "^4.12.2",
Expand Down
Loading