Skip to content

[Snyk] Fix for 1 vulnerabilities #4428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
snyk-io wants to merge 1 commit into from
Closed

[Snyk] Fix for 1 vulnerabilities #4428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions plugins/catalog-backend-module-incremental-ingestion/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,13 @@
"postpack": "backstage-cli package postpack"
},
"dependencies": {
"@backstage/backend-common": "workspace:^",
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-backend": "workspace:^",
"@backstage/plugin-catalog-backend": "1.25.0",
Comment on lines +48 to +54
Copy link
Copy Markdown

@graphite-app graphite-app Bot Mar 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR replaces workspace references with fixed versions, which breaks the monorepo's dependency management system. In a Backstage monorepo, workspace:^ references ensure consistent dependencies across packages.

The warning about the failed yarn.lock update confirms that dependency resolution is incomplete. This approach could lead to:

  1. Multiple versions of the same package in the dependency tree
  2. Inconsistent behavior between development and production
  3. Potential compatibility issues between packages

A better approach would be to:

  • Update the vulnerable dependency in the root package.json
  • Run yarn install to update all affected packages
  • Keep the workspace:^ references intact

This ensures the vulnerability is fixed while maintaining proper workspace linking throughout the monorepo.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-backend": "workspace:^",
"@backstage/plugin-catalog-backend": "1.25.0",
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/errors": "workspace:^",
"@backstage/plugin-catalog-backend": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-events-node": "workspace:^",
"@backstage/plugin-permission-common": "workspace:^",
Expand Down
Loading