Skip to content

[Snyk] Fix for 1 vulnerabilities#4458

Closed
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-928c142df93970832ebae85f6c473199
Closed

[Snyk] Fix for 1 vulnerabilities#4458
snyk-io[bot] wants to merge 1 commit intomasterfrom
snyk-fix-928c142df93970832ebae85f6c473199

Conversation

@snyk-io
Copy link
Copy Markdown

@snyk-io snyk-io Bot commented Mar 29, 2025

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.

Snyk changed the following file(s):

  • plugins/catalog-backend-module-msgraph/package.json

Note for zero-installs users

If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the .yarn/cache/ directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to run yarn to update the contents of the ./yarn/cache directory.
If you are not using zero-install you can ignore this as your flow should likely be unchanged.

⚠️ Warning
Failed to update the yarn.lock, please update manually before merging.

Vulnerabilities that will be fixed with an upgrade:

Issue Score
high severity Symlink Attack
SNYK-JS-TARFS-9535930
  721  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Summary by Sourcery

Update dependencies to fix a high-severity security vulnerability in the tar package

Bug Fixes:

  • Fix a high-severity Symlink Attack vulnerability (SNYK-JS-TARFS-9535930) by updating Backstage-related dependencies

Enhancements:

  • Replace workspace dependencies with specific version numbers for several Backstage packages

…lnerabilities

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-TARFS-9535930
@codesandbox
Copy link
Copy Markdown

codesandbox Bot commented Mar 29, 2025

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@restack-app
Copy link
Copy Markdown

restack-app Bot commented Mar 29, 2025

No applications have been configured for previews targeting branch: master. To do so go to restack console and configure your applications for previews.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Mar 29, 2025

Reviewer's Guide by Sourcery

This pull request upgrades several @backstage dependencies in plugins/catalog-backend-module-msgraph/package.json to address a reported symlink attack vulnerability. The dependencies @backstage/backend-common, @backstage/catalog-model, @backstage/plugin-catalog-common, and @backstage/plugin-catalog-node were updated to their latest versions.

Updated class diagram for package.json dependencies

classDiagram
  class PackageJson {
    dependencies: Object
  }

  PackageJson --|> Dependencies

  class Dependencies {
    -@azure/identity: string
    -@backstage/backend-common: string
    -@backstage/backend-plugin-api: string
    -@backstage/backend-tasks: string
    -@backstage/catalog-model: string
    -@backstage/config: string
    -@backstage/plugin-catalog-common: string
    -@backstage/plugin-catalog-node: string
    -@microsoft/microsoft-graph-types: string
    -@types/node-fetch: string
    -lodash: string
    -node-fetch: string
    -uuid: string
    -winston: string
  }

  note for Dependencies "Dependencies were updated to address a symlink attack vulnerability."
Loading

File-Level Changes

Change Details Files
Updated multiple @backstage dependencies to address a security vulnerability.
  • Upgraded @backstage/backend-common from workspace:^ to 0.24.1.
  • Upgraded @backstage/catalog-model from workspace:^ to 0.1.1.
  • Upgraded @backstage/plugin-catalog-common from workspace:^ to 0.1.0.
  • Upgraded @backstage/plugin-catalog-node from workspace:^ to 1.0.0.
  • Upgraded @backstage/backend-common dev dependency from workspace:^ to 0.24.1.
plugins/catalog-backend-module-msgraph/package.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. Here's why:

  • It seems to have been created by a bot (hey, snyk-io[bot]!). We assume it knows what it's doing!
  • It seems to have been created by a bot ('[Snyk]' found in title). We assume it knows what it's doing!
  • We don't review packaging changes - Let us know if you'd like us to change this.

Comment on lines +49 to +55
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/plugin-catalog-node": "1.0.0",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change replaces workspace references with fixed package versions, which may disrupt the monorepo's dependency management. The warning in the PR description confirms that the yarn.lock file wasn't properly updated, which will likely cause version inconsistencies across the project.

For monorepos using Yarn workspaces, it's generally recommended to:

  1. Keep the workspace:^ references intact
  2. Update the root package.json or other configuration to address the vulnerability
  3. Ensure yarn.lock is properly regenerated

If fixed versions are necessary, make sure to run yarn after these changes to update the lockfile and verify that all dependencies remain compatible throughout the monorepo.

Suggested change
"@backstage/backend-common": "0.24.1",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/catalog-model": "0.1.1",
"@backstage/config": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",
"@backstage/plugin-catalog-common": "0.1.0",
"@backstage/plugin-catalog-node": "1.0.0",
"@backstage/backend-common": "workspace:^",
"@backstage/backend-plugin-api": "workspace:^",
"@backstage/backend-tasks": "workspace:^",
"@backstage/catalog-model": "workspace:^",
"@backstage/config": "workspace:^",
"@backstage/plugin-catalog-common": "workspace:^",
"@backstage/plugin-catalog-node": "workspace:^",

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

@socket-security
Copy link
Copy Markdown

Report too large to display inline

View full report↗︎

@socket-security
Copy link
Copy Markdown

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Critical CVE npm/jsonpath-plus@7.1.0 ⚠︎

View full report↗︎

Next steps

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/jsonpath-plus@7.1.0

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 5, 2025

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions Bot added the stale label Apr 5, 2025
@github-actions github-actions Bot closed this Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants